hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve ZipSlip exclusion to take varargs into account

Browse Source
This commit is contained in:
Tony Torralba
2023-06-07 09:25:42 +02:00
parent 8001ae9669
commit 27763d6bbe
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/ql/lib/semmle/code/java/security/ZipSlipQuery.qll
View File

@@ -54,7 +54,10 @@ private class FileCreationSink extends DataFlow::Node {
*/
private predicate isPathCreation(DataFlow::Node sink) {
exists(PathCreation pc |
pc.getAnInput() = sink.asExpr() and
pc.getAnInput() = sink.asExpr()
or
pc.getAnInput().(Argument).isVararg() and sink.(DataFlow::ImplicitVarargsArray).getCall() = pc
|
// exclude actual read/write operations included in `PathCreation`
not pc.(Call)
.getCallee()