From 2764d697d25298f65b3e2b8b43ccd50c208535c6 Mon Sep 17 00:00:00 2001 From: Tom Hvitved Date: Mon, 26 Jan 2026 17:21:53 +0100 Subject: [PATCH] Rust: Merge `Input1` and `Input2` modules --- .../internal/typeinference/TypeInference.qll | 32 +++++++++---------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll b/rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll index e8b5c9c7a19..ca63c433feb 100644 --- a/rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll +++ b/rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll @@ -30,7 +30,7 @@ private newtype TTypeArgumentPosition = } or TTypeParamTypeArgumentPosition(TypeParam tp) -private module Input1 implements InputSig1 { +private module Input implements InputSig1, InputSig2 { private import Type as T private import codeql.rust.elements.internal.generated.Raw private import codeql.rust.elements.internal.generated.Synth @@ -120,21 +120,7 @@ private module Input1 implements InputSig1 { } int getTypePathLimit() { result = 10 } -} -private import Input1 - -private module M1 = Make1; - -import M1 - -predicate getTypePathLimit = Input1::getTypePathLimit/0; - -class TypePath = M1::TypePath; - -module TypePath = M1::TypePath; - -private module Input2 implements InputSig2 { PreTypeMention getABaseTypeMention(Type t) { none() } Type getATypeParameterConstraint(TypeParameter tp, TypePath path) { @@ -208,7 +194,19 @@ private module Input2 implements InputSig2 { } } -private module M2 = Make2; +private import Input + +private module M1 = Make1; + +import M1 + +predicate getTypePathLimit = Input::getTypePathLimit/0; + +class TypePath = M1::TypePath; + +module TypePath = M1::TypePath; + +private module M2 = Make2; import M2 @@ -4152,7 +4150,7 @@ private module Debug { TypeAbstraction abs, TypeMention condition, TypeMention constraint, boolean transitive ) { abs = getRelevantLocatable() and - Input2::conditionSatisfiesConstraint(abs, condition, constraint, transitive) + Input::conditionSatisfiesConstraint(abs, condition, constraint, transitive) } predicate debugInferShorthandSelfType(ShorthandSelfParameterMention self, TypePath path, Type t) {