hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 03:06:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

use of a single var "op" of type Cmpop

Browse Source
This commit is contained in:
Sim4n6
2024-03-13 11:07:40 +00:00
committed by yoff
parent a717bf1b9d
commit 26a16b7857
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
python/ql/src/experimental/Security/CWE-770/UnicodeDoS.ql
View File

@@ -48,28 +48,28 @@ class UnicodeCompatibilityNormalize extends API::CallNode {
predicate underAValue(DataFlow::GuardNode g, ControlFlowNode node, boolean branch) {
exists(CompareNode cn | cn = g |
exists(API::CallNode lenCall, Cmpop op_gt, Cmpop op_lt, Node n |
exists(API::CallNode lenCall, Cmpop op, Node n |
lenCall = n.getALocalSource() and
(
// arg <= LIMIT OR arg < LIMIT
(op_lt = any(LtE lte) or op_lt = any(Lt lt)) and
(op instanceof LtE or op instanceof Lt) and
branch = true and
cn.operands(n.asCfgNode(), op_lt, _)
cn.operands(n.asCfgNode(), op, _)
or
// LIMIT >= arg OR LIMIT > arg
(op_gt = any(GtE gte) or op_gt = any(Gt gt)) and
(op instanceof GtE or op instanceof Gt) and
branch = true and
cn.operands(_, op_gt, n.asCfgNode())
cn.operands(_, op, n.asCfgNode())
or
// not arg >= LIMIT OR not arg > LIMIT
(op_gt = any(GtE gte) or op_gt = any(Gt gt)) and
(op instanceof GtE or op instanceof Gt) and
branch = false and
cn.operands(n.asCfgNode(), op_gt, _)
cn.operands(n.asCfgNode(), op, _)
or
// not LIMIT <= arg OR not LIMIT < arg
(op_lt = any(LtE lte) or op_lt = any(Lt lt)) and
(op instanceof LtE or op instanceof Lt) and
branch = false and
cn.operands(_, op_lt, n.asCfgNode())
cn.operands(_, op, n.asCfgNode())
)
|
lenCall = API::builtin("len").getACall() and