hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: Avoid bad join in shared predicate induced by 'forex'.

Browse Source 
Use manual recursion instead.
This commit is contained in:
Asger F
2025-10-16 12:22:45 +02:00
parent 5dd87e379b
commit 269489e817
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
javascript/ql/lib/semmle/javascript/Expr.qll
View File

@@ -1648,13 +1648,19 @@ private string getConstantString(Expr e) {
result = e.(TemplateElement).getValue() result = e.(TemplateElement).getValue()
} }
pragma[nomagic]
private predicate hasConstantStringValue(Expr e) {
exists(getConstantString(e))
or
hasAllConstantLeafs(e.getUnderlyingValue())
}
/** /**
* Holds if `add` is a string-concatenation where all the transitive leafs have a constant string value. * Holds if `add` is a string-concatenation where all the transitive leafs have a constant string value.
*/ */
private predicate hasAllConstantLeafs(AddExpr add) { private predicate hasAllConstantLeafs(AddExpr add) {
forex(Expr leaf | leaf = getAnAddOperand*(add) and not exists(getAnAddOperand(leaf)) | hasConstantStringValue(add.getLeftOperand()) and
exists(getConstantString(leaf)) hasConstantStringValue(add.getRightOperand())
)
} }
/** /**