apply review suggestions

This commit is contained in:
Jami Cogswell
2022-09-29 15:53:00 -04:00
committed by Tony Torralba
parent 91db1be399
commit 25cb3236a2
3 changed files with 7 additions and 3 deletions

View File

@@ -2,4 +2,4 @@
category: minorAnalysis
---
* Added data flow steps for tainted Android intents that are sent to services and receivers.
* Updated data flow step for tainted Android intents that are sent to activities.
* Improved the data flow step for tainted Android intents that are sent to activities so that more cases are covered.

View File

@@ -0,0 +1,4 @@
---
category: deprecated
---
* Deprecated `ContextStartActivityMethod`. Use `StartActivityMethod` instead.

View File

@@ -221,7 +221,7 @@ class GrantWriteUriPermissionFlag extends GrantUriPermissionFlag {
GrantWriteUriPermissionFlag() { this.hasName("FLAG_GRANT_WRITE_URI_PERMISSION") }
}
/** The instantiation of an `android.content.Intent` instance. */
/** An instantiation of `android.content.Intent`. */
private class NewIntent extends ClassInstanceExpr {
NewIntent() { this.getConstructedType() instanceof TypeIntent }
@@ -232,7 +232,7 @@ private class NewIntent extends ClassInstanceExpr {
}
}
/** A call to a method that starts an Android component */
/** A call to a method that starts an Android component. */
private class StartComponentMethodAccess extends MethodAccess {
StartComponentMethodAccess() {
this.getMethod().overrides*(any(StartActivityMethod m)) or