From 25a46a82ba04025e6aab93874b4291edf295802b Mon Sep 17 00:00:00 2001 From: Mingjie Shen Date: Thu, 27 Nov 2025 05:10:58 +0000 Subject: [PATCH] C++: Use appropriate sizeof in CWE-119 memcpy tests Signed-off-by: Mingjie Shen --- .../Security/CWE/CWE-119/semmle/tests/tests.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-119/semmle/tests/tests.cpp b/cpp/ql/test/query-tests/Security/CWE/CWE-119/semmle/tests/tests.cpp index bcf10eb436a..603d868258a 100644 --- a/cpp/ql/test/query-tests/Security/CWE/CWE-119/semmle/tests/tests.cpp +++ b/cpp/ql/test/query-tests/Security/CWE/CWE-119/semmle/tests/tests.cpp @@ -30,10 +30,10 @@ void test2() char *smallbuffer = (char *)malloc(sizeof(char) * 10); char *bigbuffer = (char *)malloc(sizeof(char) * 20); - memcpy(bigbuffer, smallbuffer, 10); // GOOD - memcpy(bigbuffer, smallbuffer, 20); // BAD: over-read - memcpy(smallbuffer, bigbuffer, 10); // GOOD - memcpy(smallbuffer, bigbuffer, 20); // BAD: over-write + memcpy(bigbuffer, smallbuffer, sizeof(char) * 10); // GOOD + memcpy(bigbuffer, smallbuffer, sizeof(char) * 20); // BAD: over-read + memcpy(smallbuffer, bigbuffer, sizeof(char) * 10); // GOOD + memcpy(smallbuffer, bigbuffer, sizeof(char) * 20); // BAD: over-write free(bigbuffer); free(smallbuffer); @@ -46,10 +46,10 @@ void test3() smallbuffer = new char[10]; bigbuffer = new char[20]; - memcpy(bigbuffer, smallbuffer, 10); // GOOD - memcpy(bigbuffer, smallbuffer, 20); // BAD: over-read - memcpy(smallbuffer, bigbuffer, 10); // GOOD - memcpy(smallbuffer, bigbuffer, 20); // BAD: over-write + memcpy(bigbuffer, smallbuffer, sizeof(char[10])); // GOOD + memcpy(bigbuffer, smallbuffer, sizeof(char[20])); // BAD: over-read + memcpy(smallbuffer, bigbuffer, sizeof(char[10])); // GOOD + memcpy(smallbuffer, bigbuffer, sizeof(char[20])); // BAD: over-write delete [] bigbuffer; delete [] smallbuffer;