hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-24 16:17:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

As part of the metadata extraction predicate, surface whether or not the argument is being passed to an external API

Browse Source
This commit is contained in:
tiferet
2023-02-13 14:43:58 -08:00
parent 8f6db6b244
commit 24e01104a2
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll
View File

@@ -96,7 +96,8 @@ predicate isTypeAccess(DataFlow::Node n) { n.asExpr() instanceof TypeAccess }
predicate hasMetadata(DataFlow::Node n, string metadata) {
exists(
Callable callee, Call call, string package, string type, boolean subtypes, string name,
string signature, string ext, int input, string provenance, boolean isPublic
string signature, string ext, int input, string provenance, boolean isPublic,
boolean isExternalApiDataNode
|
n.asExpr() = call.getArgument(input) and
callee = call.getCallee() and
@@ -112,11 +113,16 @@ predicate hasMetadata(DataFlow::Node n, string metadata) {
ext = "" and // see https://github.slack.com/archives/CP9127VUK/p1673979477496069
provenance = "manual" and // TODO
(if callee.isPublic() then isPublic = true else isPublic = false) and
(
if n instanceof ExternalAPIs::ExternalApiDataNode
then isExternalApiDataNode = true
else isExternalApiDataNode = false
) and
metadata =
"{'Package': '" + package + "', 'Type': '" + type + "', 'Subtypes': " + subtypes +
", 'Name': '" + name + "', 'Signature': '" + signature + "', 'Ext': '" + ext +
"', 'Argument index': " + input + ", 'Provenance': '" + provenance + "', 'Is public': " +
isPublic + "}" // TODO: Why are the curly braces added twice?
isPublic + ", 'Is passed to external API': " + isExternalApiDataNode + "}" // TODO: Why are the curly braces added twice?
)
}