hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: Sync comment for self API graph label

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2022-06-16 11:03:07 +02:00
parent 2ad4921a76
commit 24750dcc17
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
ruby/ql/lib/codeql/ruby/ApiGraphs.qll
View File

@@ -793,13 +793,11 @@ module API {
or
pos.isAnyNamed() and
result = Label::keywordParameter(_)
//
// Note: there is currently no API graph label for `self`.
// It was omitted since in practice it means going back to where you came from.
// For example, `base.getMethod("foo").getSelf()` would just be `base`.
// However, it's possible we'll need it later, for identifying `self` parameters or post-update nodes.
// or
// pos.isSelf() and
// ...
}
/** Gets the API graph label corresponding to the given parameter position. */
@@ -829,10 +827,11 @@ module API {
or
pos.isAnyNamed() and
result = Label::keywordParameter(_)
// TODO: needs handling of `self` ParameterPosition
// or
// pos.isSelf() and
// ...
//
// Note: there is currently no API graph label for `self`.
// It was omitted since in practice it means going back to where you came from.
// For example, `base.getMethod("foo").getSelf()` would just be `base`.
// However, it's possible we'll need it later, for identifying `self` parameters or post-update nodes.
}
}
}