mirror of
https://github.com/github/codeql.git
synced 2025-12-24 04:36:35 +01:00
Address review comments.
This commit is contained in:
@@ -212,7 +212,7 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
|
||||
)
|
||||
}
|
||||
|
||||
/** Gets the textual representation of a parameter position in the format used for MaD models. */
|
||||
/** Gets the textual representation of a parameter position in the format used for flow summaries. */
|
||||
string getParameterPosition(ParameterPosition pos) {
|
||||
result = pos.getPosition().toString()
|
||||
or
|
||||
@@ -220,7 +220,7 @@ string getParameterPosition(ParameterPosition pos) {
|
||||
result = "this"
|
||||
}
|
||||
|
||||
/** Gets the textual representation of an argument position in the format used for MaD models. */
|
||||
/** Gets the textual representation of an argument position in the format used for flow summaries. */
|
||||
string getArgumentPosition(ArgumentPosition pos) {
|
||||
result = pos.getPosition().toString()
|
||||
or
|
||||
|
||||
@@ -22,10 +22,10 @@ DataFlowCallable inject(SummarizedCallable c) { result.asSummarizedCallable() =
|
||||
/** Gets the parameter position of the instance parameter. */
|
||||
ArgumentPosition callbackSelfParameterPosition() { result = -1 }
|
||||
|
||||
/** Gets the textual representation of a parameter position in the format used for MaD models. */
|
||||
/** Gets the textual representation of a parameter position in the format used for flow summaries. */
|
||||
string getParameterPosition(ParameterPosition pos) { result = pos.toString() }
|
||||
|
||||
/** Gets the textual representation of an argument position in the format used for MaD models. */
|
||||
/** Gets the textual representation of an argument position in the format used for flow summaries. */
|
||||
string getArgumentPosition(ArgumentPosition pos) { result = pos.toString() }
|
||||
|
||||
/** Gets the synthesized data-flow call for `receiver`. */
|
||||
|
||||
@@ -203,10 +203,10 @@ private string positionToString(int pos) {
|
||||
if pos = -1 then result = "this" else result = pos.toString()
|
||||
}
|
||||
|
||||
/** Gets the textual representation of a parameter position in the format used for MaD models. */
|
||||
/** Gets the textual representation of a parameter position in the format used for flow summaries. */
|
||||
string getParameterPosition(ParameterPosition pos) { result = positionToString(pos) }
|
||||
|
||||
/** Gets the textual representation of an argument position in the format used for MaD models. */
|
||||
/** Gets the textual representation of an argument position in the format used for flow summaries. */
|
||||
string getArgumentPosition(ArgumentPosition pos) { result = positionToString(pos) }
|
||||
|
||||
/** Holds if input specification component `c` needs a reference. */
|
||||
|
||||
@@ -154,7 +154,7 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
|
||||
)
|
||||
}
|
||||
|
||||
/** Gets the textual representation of a parameter position in the format used for MaD models. */
|
||||
/** Gets the textual representation of a parameter position in the format used for flow summaries. */
|
||||
string getParameterPosition(ParameterPosition pos) {
|
||||
pos.isSelf() and result = "self"
|
||||
or
|
||||
@@ -169,7 +169,7 @@ string getParameterPosition(ParameterPosition pos) {
|
||||
)
|
||||
}
|
||||
|
||||
/** Gets the textual representation of an argument position in the format used for MaD models. */
|
||||
/** Gets the textual representation of an argument position in the format used for flow summaries. */
|
||||
string getArgumentPosition(ArgumentPosition pos) {
|
||||
pos.isSelf() and result = "self"
|
||||
or
|
||||
|
||||
@@ -187,7 +187,7 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
|
||||
)
|
||||
}
|
||||
|
||||
/** Gets the textual representation of a parameter position in the format used for MaD models. */
|
||||
/** Gets the textual representation of a parameter position in the format used for flow summaries. */
|
||||
string getParameterPosition(ParameterPosition pos) {
|
||||
exists(int i |
|
||||
pos.isPositional(i) and
|
||||
@@ -220,7 +220,7 @@ string getParameterPosition(ParameterPosition pos) {
|
||||
result = "hash-splat"
|
||||
}
|
||||
|
||||
/** Gets the textual representation of an argument position in the format used for MaD models. */
|
||||
/** Gets the textual representation of an argument position in the format used for flow summaries. */
|
||||
string getArgumentPosition(ArgumentPosition pos) {
|
||||
pos.isSelf() and result = "self"
|
||||
or
|
||||
|
||||
@@ -122,10 +122,10 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
|
||||
)
|
||||
}
|
||||
|
||||
/** Gets the textual representation of a parameter position in the format used for MaD models. */
|
||||
/** Gets the textual representation of a parameter position in the format used for flow summaries. */
|
||||
string getParameterPosition(ParameterPosition pos) { result = pos.toString() }
|
||||
|
||||
/** Gets the textual representation of an argument position in the format used for MaD models. */
|
||||
/** Gets the textual representation of an argument position in the format used for flow summaries. */
|
||||
string getArgumentPosition(ArgumentPosition pos) { result = pos.toString() }
|
||||
|
||||
/** Holds if input specification component `c` needs a reference. */
|
||||
|
||||
Reference in New Issue
Block a user