hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments.

Browse Source
This commit is contained in:
Michael Nebel
2023-07-03 15:45:38 +02:00
parent b942cd9085
commit 243c592447
6 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll
View File

@@ -212,7 +212,7 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
) )
} }
/** Gets the textual representation of a parameter position in the format used for MaD models. */ /** Gets the textual representation of a parameter position in the format used for flow summaries. */
string getParameterPosition(ParameterPosition pos) { string getParameterPosition(ParameterPosition pos) {
result = pos.getPosition().toString() result = pos.getPosition().toString()
or or
@@ -220,7 +220,7 @@ string getParameterPosition(ParameterPosition pos) {
result = "this" result = "this"
} }
/** Gets the textual representation of an argument position in the format used for MaD models. */ /** Gets the textual representation of an argument position in the format used for flow summaries. */
string getArgumentPosition(ArgumentPosition pos) { string getArgumentPosition(ArgumentPosition pos) {
result = pos.getPosition().toString() result = pos.getPosition().toString()
or or

4
go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImplSpecific.qll
View File

@@ -22,10 +22,10 @@ DataFlowCallable inject(SummarizedCallable c) { result.asSummarizedCallable() =
/** Gets the parameter position of the instance parameter. */ /** Gets the parameter position of the instance parameter. */
ArgumentPosition callbackSelfParameterPosition() { result = -1 } ArgumentPosition callbackSelfParameterPosition() { result = -1 }
/** Gets the textual representation of a parameter position in the format used for MaD models. */ /** Gets the textual representation of a parameter position in the format used for flow summaries. */
string getParameterPosition(ParameterPosition pos) { result = pos.toString() } string getParameterPosition(ParameterPosition pos) { result = pos.toString() }
/** Gets the textual representation of an argument position in the format used for MaD models. */ /** Gets the textual representation of an argument position in the format used for flow summaries. */
string getArgumentPosition(ArgumentPosition pos) { result = pos.toString() } string getArgumentPosition(ArgumentPosition pos) { result = pos.toString() }
/** Gets the synthesized data-flow call for `receiver`. */ /** Gets the synthesized data-flow call for `receiver`. */

4
java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll
View File

@@ -203,10 +203,10 @@ private string positionToString(int pos) {
if pos = -1 then result = "this" else result = pos.toString() if pos = -1 then result = "this" else result = pos.toString()
} }
/** Gets the textual representation of a parameter position in the format used for MaD models. */ /** Gets the textual representation of a parameter position in the format used for flow summaries. */
string getParameterPosition(ParameterPosition pos) { result = positionToString(pos) } string getParameterPosition(ParameterPosition pos) { result = positionToString(pos) }
/** Gets the textual representation of an argument position in the format used for MaD models. */ /** Gets the textual representation of an argument position in the format used for flow summaries. */
string getArgumentPosition(ArgumentPosition pos) { result = positionToString(pos) } string getArgumentPosition(ArgumentPosition pos) { result = positionToString(pos) }
/** Holds if input specification component `c` needs a reference. */ /** Holds if input specification component `c` needs a reference. */

4
python/ql/lib/semmle/python/dataflow/new/internal/FlowSummaryImplSpecific.qll
View File

@@ -154,7 +154,7 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
) )
} }
/** Gets the textual representation of a parameter position in the format used for MaD models. */ /** Gets the textual representation of a parameter position in the format used for flow summaries. */
string getParameterPosition(ParameterPosition pos) { string getParameterPosition(ParameterPosition pos) {
pos.isSelf() and result = "self" pos.isSelf() and result = "self"
or or
@@ -169,7 +169,7 @@ string getParameterPosition(ParameterPosition pos) {
) )
} }
/** Gets the textual representation of an argument position in the format used for MaD models. */ /** Gets the textual representation of an argument position in the format used for flow summaries. */
string getArgumentPosition(ArgumentPosition pos) { string getArgumentPosition(ArgumentPosition pos) {
pos.isSelf() and result = "self" pos.isSelf() and result = "self"
or or

4
ruby/ql/lib/codeql/ruby/dataflow/internal/FlowSummaryImplSpecific.qll
View File

@@ -187,7 +187,7 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
) )
} }
/** Gets the textual representation of a parameter position in the format used for MaD models. */ /** Gets the textual representation of a parameter position in the format used for flow summaries. */
string getParameterPosition(ParameterPosition pos) { string getParameterPosition(ParameterPosition pos) {
exists(int i | exists(int i |
pos.isPositional(i) and pos.isPositional(i) and
@@ -220,7 +220,7 @@ string getParameterPosition(ParameterPosition pos) {
result = "hash-splat" result = "hash-splat"
} }
/** Gets the textual representation of an argument position in the format used for MaD models. */ /** Gets the textual representation of an argument position in the format used for flow summaries. */
string getArgumentPosition(ArgumentPosition pos) { string getArgumentPosition(ArgumentPosition pos) {
pos.isSelf() and result = "self" pos.isSelf() and result = "self"
or or

4
swift/ql/lib/codeql/swift/dataflow/internal/FlowSummaryImplSpecific.qll
View File

@@ -122,10 +122,10 @@ string getMadRepresentationSpecific(SummaryComponent sc) {
) )
} }
/** Gets the textual representation of a parameter position in the format used for MaD models. */ /** Gets the textual representation of a parameter position in the format used for flow summaries. */
string getParameterPosition(ParameterPosition pos) { result = pos.toString() } string getParameterPosition(ParameterPosition pos) { result = pos.toString() }
/** Gets the textual representation of an argument position in the format used for MaD models. */ /** Gets the textual representation of an argument position in the format used for flow summaries. */
string getArgumentPosition(ArgumentPosition pos) { result = pos.toString() } string getArgumentPosition(ArgumentPosition pos) { result = pos.toString() }
/** Holds if input specification component `c` needs a reference. */ /** Holds if input specification component `c` needs a reference. */