hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java/C++/C#: Address review comment.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2020-01-14 11:59:55 +01:00
parent 041bcc5812
commit 241b8a05e4
19 changed files with 19 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl.qll
View File

@@ -853,8 +853,7 @@ private predicate readStoreCandFwd2(Content f, Configuration config) {
}
private predicate summaryFwd2(Summary s, Configuration config) {
s = TSummaryTaint()
or
// No need for the `s = TSummaryTaint()` case as it is not used with `argumentFlowsThroughFwd2`.
exists(Content f | s = TSummaryReadTaint(f) | readStoreCandFwd2(f, config))
or
exists(Content f | s = TSummaryTaintStore(f) | readStoreCandFwd2(f, config))

3
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl2.qll
View File

@@ -853,8 +853,7 @@ private predicate readStoreCandFwd2(Content f, Configuration config) {
}
private predicate summaryFwd2(Summary s, Configuration config) {
s = TSummaryTaint()
or
// No need for the `s = TSummaryTaint()` case as it is not used with `argumentFlowsThroughFwd2`.
exists(Content f | s = TSummaryReadTaint(f) | readStoreCandFwd2(f, config))
or
exists(Content f | s = TSummaryTaintStore(f) | readStoreCandFwd2(f, config))

3
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl3.qll
View File

@@ -853,8 +853,7 @@ private predicate readStoreCandFwd2(Content f, Configuration config) {
}
private predicate summaryFwd2(Summary s, Configuration config) {
s = TSummaryTaint()
or
// No need for the `s = TSummaryTaint()` case as it is not used with `argumentFlowsThroughFwd2`.
exists(Content f | s = TSummaryReadTaint(f) | readStoreCandFwd2(f, config))
or
exists(Content f | s = TSummaryTaintStore(f) | readStoreCandFwd2(f, config))

3
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl4.qll
View File

@@ -853,8 +853,7 @@ private predicate readStoreCandFwd2(Content f, Configuration config) {
}
private predicate summaryFwd2(Summary s, Configuration config) {
s = TSummaryTaint()
or
// No need for the `s = TSummaryTaint()` case as it is not used with `argumentFlowsThroughFwd2`.
exists(Content f | s = TSummaryReadTaint(f) | readStoreCandFwd2(f, config))
or
exists(Content f | s = TSummaryTaintStore(f) | readStoreCandFwd2(f, config))

3
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl5.qll
View File

@@ -853,8 +853,7 @@ private predicate readStoreCandFwd2(Content f, Configuration config) {
}
private predicate summaryFwd2(Summary s, Configuration config) {
s = TSummaryTaint()
or
// No need for the `s = TSummaryTaint()` case as it is not used with `argumentFlowsThroughFwd2`.
exists(Content f | s = TSummaryReadTaint(f) | readStoreCandFwd2(f, config))
or
exists(Content f | s = TSummaryTaintStore(f) | readStoreCandFwd2(f, config))