hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix isParameterDeref typo.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-01-28 18:29:30 +01:00
parent 75aa1e8a3b
commit 23eb4d2009
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/semmle/code/cpp/models/implementations/Strset.qll
View File

@@ -34,7 +34,7 @@ private class StrsetFunction extends ArrayFunction, DataFlowFunction, AliasFunct
(
output.isReturnValueDeref()
or
output.isParameterDeref(1)
output.isParameterDeref(0)
)
or
// flow from the input string to the output string

2
cpp/ql/test/library-tests/dataflow/taint-tests/localTaint.expected
View File

@@ -5874,6 +5874,7 @@
| taint.cpp:504:10:504:12 | ref arg ptr | taint.cpp:505:7:505:9 | ptr | |
| taint.cpp:504:10:504:12 | ref arg ptr | taint.cpp:506:8:506:10 | ptr | |
| taint.cpp:504:15:504:20 | source | taint.cpp:504:2:504:8 | call to _strset | TAINT |
| taint.cpp:504:15:504:20 | source | taint.cpp:504:10:504:12 | ref arg ptr | |
| taint.cpp:505:7:505:9 | ref arg ptr | taint.cpp:506:8:506:10 | ptr | |
| taint.cpp:506:8:506:10 | ptr | taint.cpp:506:7:506:10 | * ... | TAINT |
| taint.cpp:509:26:509:31 | source | taint.cpp:510:10:510:15 | source | |
@@ -5881,6 +5882,7 @@
| taint.cpp:510:10:510:15 | ref arg source | taint.cpp:511:7:511:12 | source | |
| taint.cpp:510:10:510:15 | source | taint.cpp:510:2:510:8 | call to _strset | |
| taint.cpp:510:18:510:18 | 0 | taint.cpp:510:2:510:8 | call to _strset | TAINT |
| taint.cpp:510:18:510:18 | 0 | taint.cpp:510:10:510:15 | ref arg source | |
| vector.cpp:16:43:16:49 | source1 | vector.cpp:17:26:17:32 | source1 | |
| vector.cpp:16:43:16:49 | source1 | vector.cpp:31:38:31:44 | source1 | |
| vector.cpp:17:21:17:33 | call to vector | vector.cpp:19:14:19:14 | v | |

4
cpp/ql/test/library-tests/dataflow/taint-tests/taint.cpp
View File

@@ -502,8 +502,8 @@ char *_strset(char *str, int c);
void test_strset_1(char* ptr, char source) {
_strset(ptr, source);
sink(ptr);
sink(*ptr); // $ MISSING: ast,ir
sink(ptr); // $ SPURIOUS: ast,ir
sink(*ptr); // $ ast,ir
}
void test_strset_2(char* source) {