hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Deprecate property lookup on types

Browse Source
This commit is contained in:
Asger Feldthaus
2020-06-23 11:42:28 +01:00
parent 39137510ba
commit 234f968294
18 changed files with 31 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
javascript/ql/test/library-tests/TypeScript/ArrayTypes/ArrayTypes.expected
View File

@@ -1,20 +1,5 @@
| (T \| ConcatArray<T>)[] | `T \| ConcatArray<T>` |
| (number \| ConcatArray<number>)[] | `number \| ConcatArray<number>` |
| (number[] \| ConcatArray<number[]>)[] | `number[] \| ConcatArray<number[]>` |
| (string \| number \| ConcatArray<string \| number>)[] | `string \| number \| ConcatArray<string \| number>` |
| (string \| number)[] | `string \| number` |
| ConcatArray<T>[] | `ConcatArray<T>` |
| ConcatArray<number>[] | `ConcatArray<number>` |
| ConcatArray<number[]>[] | `ConcatArray<number[]>` |
| ConcatArray<string \| number>[] | `ConcatArray<string \| number>` |
| S[] | `S` |
| T[] | `T` |
| U[] | `U` |
| [number, string] | `string \| number` |
| any[] | `any` |
| number[] | `number` |
| number[][] | `number[]` |
| readonly T[] | `T` |
| readonly number[] | `number` |
| readonly number[][] | `number[]` |
| string[] | `string` |

15
javascript/ql/test/library-tests/TypeScript/ArrayTypes/NumberIndexTypes.expected
View File

@@ -1,22 +1,7 @@
| (T \| ConcatArray<T>)[] | T \| ConcatArray<T> |
| (number \| ConcatArray<number>)[] | number \| ConcatArray<number> |
| (number[] \| ConcatArray<number[]>)[] | number[] \| ConcatArray<number[]> |
| (string \| number \| ConcatArray<string \| number>)[] | string \| number \| ConcatArray<string \| number> |
| (string \| number)[] | string \| number |
| ConcatArray<T>[] | ConcatArray<T> |
| ConcatArray<number>[] | ConcatArray<number> |
| ConcatArray<number[]>[] | ConcatArray<number[]> |
| ConcatArray<string \| number>[] | ConcatArray<string \| number> |
| NumberIndexable | object |
| S[] | S |
| T[] | T |
| U[] | U |
| [number, string] | string \| number |
| any[] | any |
| number[] | number |
| number[][] | number[] |
| readonly T[] | T |
| readonly number[] | number |
| readonly number[][] | number[] |
| string | string |
| string[] | string |

1
javascript/ql/test/library-tests/TypeScript/ArrayTypes/TupleTypes.expected
View File

@@ -1 +0,0 @@
| [number, string] | (string \| number)[] |

1
javascript/ql/test/library-tests/TypeScript/BaseTypes/BaseTypes.expected
View File

@@ -13,4 +13,3 @@
| IMulti | IGenericBase |
| IStringSub | IGenericBase |
| ISub | IBase |
| RegExpMatchArray | Array |

4
javascript/ql/test/library-tests/TypeScript/BaseTypes/SelfTypes.expected
View File

@@ -7,7 +7,6 @@
| CImplementsString | CImplementsString |
| CStringSub | CStringSub |
| CSub | CSub |
| CollatorOptions | CollatorOptions |
| IBase | IBase |
| IEmpty | IEmpty |
| IEmptySub | IEmptySub |
@@ -16,6 +15,3 @@
| IMulti | IMulti<T> |
| IStringSub | IStringSub |
| ISub | ISub |
| NumberFormatOptions | NumberFormatOptions |
| RegExp | RegExp |
| RegExpMatchArray | RegExpMatchArray |

27
javascript/ql/test/library-tests/TypeScript/CallSignatureTypes/test.expected
View File

@@ -108,51 +108,24 @@ test_FunctionCallSig
| tst.ts:63:3:63:23 | method2 ... ing[]); | (y: string[]): any |
| tst.ts:64:3:64:21 | method3(y: string); | (y: string): any |
test_getRestParameterType
| (...items: (string \| ConcatArray<string>)[]): T[] | string \| ConcatArray<string> |
| (...items: ConcatArray<string>[]): T[] | ConcatArray<string> |
| (...items: string[]): number | string |
| (...strings: string[]): string | string |
| (...y: string[]): any | string |
| (start: number, deleteCount: number, ...items: string[]): T[] | string |
| (substring: string, ...args: any[]): string | any |
| (x: number, ...y: string[]): any | string |
| new (...y: string[]): any | string |
| new (x: number, ...y: string[]): any | string |
test_getRestParameterArray
| (...items: (string \| ConcatArray<string>)[]): T[] | (string \| ConcatArray<string>)[] |
| (...items: ConcatArray<string>[]): T[] | ConcatArray<string>[] |
| (...items: string[]): number | string[] |
| (...strings: string[]): string | string[] |
| (...y: string[]): any | string[] |
| (start: number, deleteCount: number, ...items: string[]): T[] | string[] |
| (substring: string, ...args: any[]): string | any[] |
| (x: number, ...y: string[]): any | string[] |
| new (...y: string[]): any | string[] |
| new (x: number, ...y: string[]): any | string[] |
test_RestSig_getParameter
| (...items: (string \| ConcatArray<string>)[]): T[] | 0 | items | string \| ConcatArray<string> |
| (...items: ConcatArray<string>[]): T[] | 0 | items | ConcatArray<string> |
| (...items: string[]): number | 0 | items | string |
| (...strings: string[]): string | 0 | strings | string |
| (...y: string[]): any | 0 | y | string |
| (start: number, deleteCount: number, ...items: string[]): T[] | 0 | start | number |
| (start: number, deleteCount: number, ...items: string[]): T[] | 1 | deleteCount | number |
| (start: number, deleteCount: number, ...items: string[]): T[] | 2 | items | string |
| (substring: string, ...args: any[]): string | 0 | substring | string |
| (substring: string, ...args: any[]): string | 1 | args | any |
| (x: number, ...y: string[]): any | 0 | x | number |
| (x: number, ...y: string[]): any | 1 | y | string |
| new (...y: string[]): any | 0 | y | string |
| new (x: number, ...y: string[]): any | 0 | x | number |
| new (x: number, ...y: string[]): any | 1 | y | string |
test_RestSig_numRequiredParams
| (...items: (string \| ConcatArray<string>)[]): T[] | 0 |
| (...items: ConcatArray<string>[]): T[] | 0 |
| (...items: string[]): number | 0 |
| (...strings: string[]): string | 0 |
| (...y: string[]): any | 0 |
| (start: number, deleteCount: number, ...items: string[]): T[] | 2 |
| (substring: string, ...args: any[]): string | 1 |
| (x: number, ...y: string[]): any | 1 |
| new (...y: string[]): any | 0 |
| new (x: number, ...y: string[]): any | 1 |

6
javascript/ql/test/library-tests/TypeScript/ExpansiveTypes/ExpansiveTypes.expected
View File

@@ -1,3 +1,8 @@
WARNING: Predicate getProperty has been deprecated and may be removed in future (ExpansiveTypes.ql:5,19-30)
| After in library-tests/TypeScript/ExpansiveTypes/leading_into_expansion.ts | has no properties |
| AfterX in library-tests/TypeScript/ExpansiveTypes/used_from_expansion.ts | has no properties |
| Before in library-tests/TypeScript/ExpansiveTypes/leading_into_expansion.ts | has no properties |
| BeforeX in library-tests/TypeScript/ExpansiveTypes/used_from_expansion.ts | has no properties |
| Box in library-tests/TypeScript/ExpansiveTypes/shared_non_expansive.ts | has no properties |
| Box in library-tests/TypeScript/ExpansiveTypes/through_non_expansive.ts | has no properties |
| C in library-tests/TypeScript/ExpansiveTypes/expansive_class.ts | has no properties |
@@ -21,3 +26,4 @@
| ExpansiveSignature in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has no properties |
| ExpansiveSignatureTypeBound in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has no properties |
| ExpansiveX in library-tests/TypeScript/ExpansiveTypes/used_from_expansion.ts | has no properties |
| NonExpansive in library-tests/TypeScript/ExpansiveTypes/shared_non_expansive.ts | has no properties |

32
javascript/ql/test/library-tests/TypeScript/ExpansiveTypes/NonExpansiveTypes.expected
View File

@@ -1,31 +1 @@
| After in library-tests/TypeScript/ExpansiveTypes/leading_into_expansion.ts | has properties |
| AfterX in library-tests/TypeScript/ExpansiveTypes/used_from_expansion.ts | has properties |
| Array in global scope | has properties |
| Before in library-tests/TypeScript/ExpansiveTypes/leading_into_expansion.ts | has properties |
| BeforeX in library-tests/TypeScript/ExpansiveTypes/used_from_expansion.ts | has properties |
| Box in library-tests/TypeScript/ExpansiveTypes/shared_non_expansive.ts | has properties |
| Box in library-tests/TypeScript/ExpansiveTypes/through_non_expansive.ts | has properties |
| C in library-tests/TypeScript/ExpansiveTypes/expansive_class.ts | has properties |
| Expand in library-tests/TypeScript/ExpansiveTypes/through_non_expansive.ts | has properties |
| ExpandUsingObjectLiteral in library-tests/TypeScript/ExpansiveTypes/expansive_object_literal.ts | has properties |
| Expansive in library-tests/TypeScript/ExpansiveTypes/leading_into_expansion.ts | has properties |
| Expansive in library-tests/TypeScript/ExpansiveTypes/simple.ts | has properties |
| ExpansiveA in library-tests/TypeScript/ExpansiveTypes/mutual.ts | has properties |
| ExpansiveA in library-tests/TypeScript/ExpansiveTypes/mutual_multigraph.ts | has properties |
| ExpansiveB in library-tests/TypeScript/ExpansiveTypes/mutual.ts | has properties |
| ExpansiveB in library-tests/TypeScript/ExpansiveTypes/mutual_multigraph.ts | has properties |
| ExpansiveByInference in library-tests/TypeScript/ExpansiveTypes/expansive_by_inference.ts | has properties |
| ExpansiveC in library-tests/TypeScript/ExpansiveTypes/mutual.ts | has properties |
| ExpansiveC in library-tests/TypeScript/ExpansiveTypes/mutual_multigraph.ts | has properties |
| ExpansiveConstructSignature in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has properties |
| ExpansiveD in library-tests/TypeScript/ExpansiveTypes/mutual.ts | has properties |
| ExpansiveD in library-tests/TypeScript/ExpansiveTypes/mutual_multigraph.ts | has properties |
| ExpansiveFunctionType in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has properties |
| ExpansiveMethod in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has properties |
| ExpansiveParameter in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has properties |
| ExpansiveSignature in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has properties |
| ExpansiveSignatureTypeBound in library-tests/TypeScript/ExpansiveTypes/expansive_signature.ts | has properties |
| ExpansiveX in library-tests/TypeScript/ExpansiveTypes/used_from_expansion.ts | has properties |
| Intl.CollatorOptions in global scope | has properties |
| Intl.NumberFormatOptions in global scope | has properties |
| NonExpansive in library-tests/TypeScript/ExpansiveTypes/shared_non_expansive.ts | has properties |
WARNING: Predicate getProperty has been deprecated and may be removed in future (NonExpansiveTypes.ql:4,19-30)

4
javascript/ql/test/library-tests/TypeScript/ExternalTypes/GlobalQualifiedNames.expected
View File

@@ -1,8 +1,4 @@
| Intl.CollatorOptions | CollatorOptions |
| Intl.NumberFormatOptions | NumberFormatOptions |
| LegacyGlobals.LegacySubclass | LegacySubclass |
| Modern.ModernClass | ModernClass |
| ModernGlobals.ModernSubclass | ModernSubclass |
| RegExp | RegExp |
| RegExpMatchArray | RegExpMatchArray |
| __Legacy.LegacyClass | LegacyClass |

4
javascript/ql/test/library-tests/TypeScript/ExternalTypes/Types.expected
View File

@@ -1,5 +1,4 @@
| Augmentation | defined in augmentation.ts |
| CollatorOptions | has no definition |
| ExternalType1 | has no definition |
| ExternalType2 | has no definition |
| InternalType | defined in client_esmodule.ts |
@@ -7,9 +6,6 @@
| LegacySubclass | has no definition |
| ModernClass | has no definition |
| ModernSubclass | has no definition |
| NumberFormatOptions | has no definition |
| OtherClass | has no definition |
| RegExp | has no definition |
| RegExpMatchArray | has no definition |
| UtilClass | has no definition |
| UtilExtraClass | has no definition |

8
javascript/ql/test/library-tests/TypeScript/LexicalTypes/TypeReferences.expected
View File

@@ -1,24 +1,16 @@
| C<Bar> | 1 | bar.ts:10:10:10:24 | class C<Bar> {} |
| C<Foo> | 1 | foo.ts:10:10:10:24 | class C<Foo> {} |
| C<any> | 1 | bar.ts:10:10:10:24 | class C<Bar> {} |
| C<any> | 1 | foo.ts:10:10:10:24 | class C<Foo> {} |
| C<number> | 1 | bar.ts:10:10:10:24 | class C<Bar> {} |
| C<number> | 1 | foo.ts:10:10:10:24 | class C<Foo> {} |
| ExportedClass<Bar> | 1 | bar.ts:4:8:4:34 | class E ... Bar> {} |
| ExportedClass<Foo> | 1 | foo.ts:4:8:4:34 | class E ... Foo> {} |
| ExportedClass<any> | 1 | bar.ts:4:8:4:34 | class E ... Bar> {} |
| ExportedClass<any> | 1 | foo.ts:4:8:4:34 | class E ... Foo> {} |
| ExportedClass<number> | 1 | bar.ts:4:8:4:34 | class E ... Bar> {} |
| ExportedClass<number> | 1 | foo.ts:4:8:4:34 | class E ... Foo> {} |
| InnerC<Foo1> | 1 | foo.ts:13:3:13:23 | class I ... oo1> {} |
| InnerC<Foo2> | 1 | foo.ts:18:3:18:23 | class I ... oo2> {} |
| InnerC<any> | 1 | foo.ts:13:3:13:23 | class I ... oo1> {} |
| InnerC<any> | 1 | foo.ts:18:3:18:23 | class I ... oo2> {} |
| InnerC<number> | 1 | foo.ts:13:3:13:23 | class I ... oo1> {} |
| InnerC<number> | 1 | foo.ts:18:3:18:23 | class I ... oo2> {} |
| LocalClass<Bar> | 1 | bar.ts:3:1:3:24 | class L ... Bar> {} |
| LocalClass<Foo> | 1 | foo.ts:3:1:3:24 | class L ... Foo> {} |
| LocalClass<any> | 1 | bar.ts:3:1:3:24 | class L ... Bar> {} |
| LocalClass<any> | 1 | foo.ts:3:1:3:24 | class L ... Foo> {} |
| LocalClass<number> | 1 | bar.ts:3:1:3:24 | class L ... Bar> {} |
| LocalClass<number> | 1 | foo.ts:3:1:3:24 | class L ... Foo> {} |

1
javascript/ql/test/library-tests/TypeScript/QualifiedNameResolution/Namespaces.expected
View File

@@ -20,7 +20,6 @@
| Glob in global scope |
| H in namespaces.ts:27 |
| H.I in namespaces.ts:27 |
| Intl in global scope |
| N in library-tests/TypeScript/QualifiedNameResolution/export-specifiers.ts |
| X in global scope |
| X in library-tests/TypeScript/QualifiedNameResolution/namespaces.ts |

6
javascript/ql/test/library-tests/TypeScript/RegressionTests/EmptyName/test.expected
View File

@@ -1,10 +1,4 @@
| Array in global scope |
| Intl in global scope |
| Intl.CollatorOptions in global scope |
| Intl.NumberFormatOptions in global scope |
| MK in unknown scope |
| Mapped in library-tests/TypeScript/RegressionTests/EmptyName/test.ts |
| RegExp in global scope |
| RegExpMatchArray in global scope |
| fn in library-tests/TypeScript/RegressionTests/EmptyName/test.ts |
| library-tests/TypeScript/RegressionTests/EmptyName/test.ts |

2
javascript/ql/test/library-tests/TypeScript/RegressionTests/SemicolonInName/test.expected
View File

@@ -1,4 +1,2 @@
| Bar.Foo in global scope | Bar in global scope |
| Intl.CollatorOptions in global scope | Intl in global scope |
| Intl.NumberFormatOptions in global scope | Intl in global scope |
| fn in library-tests/TypeScript/RegressionTests/SemicolonInName/test.ts | library-tests/TypeScript/RegressionTests/SemicolonInName/test.ts |

1
javascript/ql/test/library-tests/TypeScript/TypeVariableTypes/LexicalTypeVariables.expected
View File

@@ -1,4 +1,3 @@
| D | D |
| E | E |
| S | S |
| U | U |

12
javascript/ql/test/library-tests/TypeScript/TypeVariableTypes/SignatureTypeParameters.expected
View File

@@ -2,18 +2,6 @@
| <E>(x: () => E): E | 1 | 0 | E | no bound |
| <E>(x: E[] \| (() => E)): E | 1 | 0 | E | no bound |
| <E>(x: E[]): E | 1 | 0 | E | no bound |
| <S extends E>(callbackfn: (value: E, index: number, array: E[]) => va... | 1 | 0 | S | no bound |
| <S extends T \| S>(callbackfn: (value: T \| S, index: number, array: (T... | 1 | 0 | S | no bound |
| <S extends T>(callbackfn: (value: T, index: number, array: T[]) => va... | 1 | 0 | S | no bound |
| <S extends any>(callbackfn: (value: any, index: number, array: any[])... | 1 | 0 | S | any |
| <S extends any[]>(x: S, y: T[]): S | 1 | 0 | S | any[] |
| <S>(x: S, y: S): S | 1 | 0 | S | no bound |
| <S>(x: S, y: T): [S, T] | 1 | 0 | S | no bound |
| <U>(callbackfn: (previousValue: U, currentValue: E, currentIndex: num... | 1 | 0 | U | no bound |
| <U>(callbackfn: (previousValue: U, currentValue: T \| S, currentIndex:... | 1 | 0 | U | no bound |
| <U>(callbackfn: (previousValue: U, currentValue: T, currentIndex: num... | 1 | 0 | U | no bound |
| <U>(callbackfn: (previousValue: U, currentValue: any, currentIndex: n... | 1 | 0 | U | no bound |
| <U>(callbackfn: (value: E, index: number, array: E[]) => U, thisArg?:... | 1 | 0 | U | no bound |
| <U>(callbackfn: (value: T \| S, index: number, array: (T \| S)[]) => U,... | 1 | 0 | U | no bound |
| <U>(callbackfn: (value: T, index: number, array: T[]) => U, thisArg?:... | 1 | 0 | U | no bound |
| <U>(callbackfn: (value: any, index: number, array: any[]) => U, thisA... | 1 | 0 | U | no bound |