hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Deprecate property lookup on types

Browse Source
This commit is contained in:
Asger Feldthaus
2020-06-23 11:42:28 +01:00
parent 39137510ba
commit 234f968294
18 changed files with 31 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
javascript/extractor/lib/typescript/src/type_table.ts
View File

@@ -875,21 +875,23 @@ export class TypeTable {
}
/**
* Returns the properties of the given type, or `null` if the properties of this
* type could not be computed.
* Returns the properties to extract for the given type or `null` if nothing should be extracted.
*
* For performance reasons we only extract properties needed to recognize promise types at the QL
* level.
*/
private tryGetProperties(type: ts.Type) {
// Workaround for https://github.com/Microsoft/TypeScript/issues/30845
// Should be safe to remove once that has been fixed.
try {
return type.getProperties();
} catch (e) {
return null;
private getPropertiesToExtract(type: ts.Type) {
if (this.getSelfType(type) === type) {
let thenSymbol = this.typeChecker.getPropertyOfType(type, "then");
if (thenSymbol != null) {
return [thenSymbol];
}
}
return null;
}
private extractProperties(type: ts.Type, id: number) {
let props = this.tryGetProperties(type);
let props = this.getPropertiesToExtract(type);
if (props == null) return;
for (let symbol of props) {
let propertyType = this.tryGetTypeOfSymbol(symbol);