hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 23:35:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: Address review comments

Browse Source
This commit is contained in:
Harry Maclean
2024-01-02 14:39:53 +00:00
parent 4c6855ed93
commit 22830c7311
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ruby/ql/src/utils/modeleditor/ModelEditor.qll
View File

@@ -61,15 +61,15 @@ abstract class Endpoint instanceof DataFlow::Node {
/**
* A callable method or accessor from source code.
*/
class MethodEndpoint extends Endpoint {
class MethodEndpoint extends Endpoint instanceof DataFlow::MethodNode {
MethodEndpoint() {
this.(DataFlow::MethodNode).isPublic() and
this.isPublic() and
not isUninteresting(this)
}
DataFlow::MethodNode getNode() { result = this }
override string getName() { result = this.(DataFlow::MethodNode).getMethodName() }
override string getName() { result = super.getMethodName() }
/**
* Gets the unbound type name of this endpoint.
@@ -91,15 +91,10 @@ class MethodEndpoint extends Endpoint {
result =
"(" +
concat(string key, string value |
value =
any(int i |
i.toString() = key
|
this.(DataFlow::MethodNode).asCallable().getParameter(i)
).getName()
value = any(int i | i.toString() = key | super.asCallable().getParameter(i)).getName()
or
exists(DataFlow::ParameterNode param |
param = this.(DataFlow::MethodNode).asCallable().getKeywordParameter(key)
param = super.asCallable().getKeywordParameter(key)
|
value = key + ":"
)