hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

stop spuriously matching everything when encountering an unsupported charclass

Browse Source
This commit is contained in:
erik-krogh
2023-06-15 12:49:02 +02:00
parent e8b12ce416
commit 21b55ce0cf
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
shared/regex/codeql/regex/nfa/NfaUtils.qll
View File

@@ -451,7 +451,15 @@ module Make<RegexTreeViewSig TreeImpl> {
}
bindingset[char]
override predicate matches(string char) { not hasChildThatMatches(cc, char) }
override predicate matches(string char) {
not hasChildThatMatches(cc, char) and
(
// detect unsupported char classes that doesn't match anything (e.g. `\p{L}` in ruby), and don't report any matches
exists(string c | hasChildThatMatches(cc, c))
or
not exists(cc.getAChild()) // [^] still matches everything
)
}
}
/**
@@ -536,7 +544,9 @@ module Make<RegexTreeViewSig TreeImpl> {
bindingset[char]
override predicate matches(string char) {
not classEscapeMatches(charClass.toLowerCase(), char)
not classEscapeMatches(charClass.toLowerCase(), char) and
// detect unsupported char classes (e.g. `\p{L}` in ruby), and don't report any matches
exists(string c | classEscapeMatches(charClass.toLowerCase(), c))
}
}