hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Bazel/Go: make @codeql//go:gen runnable from internal repo

Browse Source
This commit is contained in:
Paolo Tranquilli
2024-05-03 14:52:17 +02:00
parent 8f0b88497a
commit 2132c7bf96
2 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
go/BUILD.bazel
View File

@@ -1,13 +1,14 @@
load("@bazel_skylib//rules:native_binary.bzl", "native_binary") load("@bazel_skylib//rules:native_binary.bzl", "native_binary")
load("@gazelle//:def.bzl", "gazelle")
load("@rules_pkg//pkg:install.bzl", "pkg_install") load("@rules_pkg//pkg:install.bzl", "pkg_install")
load("@rules_pkg//pkg:mappings.bzl", "pkg_attributes", "pkg_filegroup", "pkg_files") load("@rules_pkg//pkg:mappings.bzl", "pkg_attributes", "pkg_filegroup", "pkg_files")
load("@rules_pkg//pkg:zip.bzl", "pkg_zip") load("@rules_pkg//pkg:zip.bzl", "pkg_zip")
load("//:defs.bzl", "codeql_platform") load("//:defs.bzl", "codeql_platform")
gazelle( native_binary(
name = "gazelle", name = "gazelle",
extra_args = ["go/extractor"], src = "@gazelle//cmd/gazelle",
out = "gazelle.exe",
args = ["go/extractor"],
) )
_gen_binaries = [ _gen_binaries = [
@@ -24,9 +25,9 @@ py_binary(
deps = ["@rules_python//python/runfiles"], deps = ["@rules_python//python/runfiles"],
) )
# this is an internal copy of the dbscheme to be used by extractor-pack # this is an instance of the dbscheme kept in the bazel build tree
# this allows the extractor-pack target to be independent and up-to-date with respect to # this allows everything that bazel builds to be up-to-date,
# having run //go:gen to update the checked in files # independently from whether //go:gen was already run to update the checked in files
genrule( genrule(
name = "dbscheme", name = "dbscheme",
outs = ["go.dbscheme"], outs = ["go.dbscheme"],
@@ -108,12 +109,3 @@ py_binary(
main = "create_extractor_pack.py", main = "create_extractor_pack.py",
deps = ["@rules_python//python/runfiles"], deps = ["@rules_python//python/runfiles"],
) )
native_binary(
name = "gen-dbscheme",
src = "//go/extractor/cli/go-gen-dbscheme",
out = "go-gen-dbscheme",
args = [
"$$BUILD_WORKSPACE_DIRECTORY/go/ql/lib/go.dbscheme",
],
)

12
go/gen.py
View File

@@ -24,12 +24,18 @@ def options():
opts = options() opts = options()
try: try:
workspace_dir = pathlib.Path(os.environ['BUILD_WORKSPACE_DIRECTORY']) workspace_dir = pathlib.Path(os.environ.pop('BUILD_WORKSPACE_DIRECTORY'))
except KeyError: except KeyError:
print("this should be run with bazel run", file=sys.stderr) print("this should be run with bazel run", file=sys.stderr)
sys.exit(1) sys.exit(1)
go_extractor_dir = workspace_dir / "go" / "extractor" go_extractor_dir = workspace_dir / "go" / "extractor"
if not go_extractor_dir.exists():
# internal repo?
workspace_dir /= "ql"
go_extractor_dir = workspace_dir / "go" / "extractor"
go_dbscheme = workspace_dir / "go" / "ql" / "lib" / "go.dbscheme" go_dbscheme = workspace_dir / "go" / "ql" / "lib" / "go.dbscheme"
r = runfiles.Create() r = runfiles.Create()
go, gazelle, go_gen_dbscheme = map(r.Rlocation, opts.executables) go, gazelle, go_gen_dbscheme = map(r.Rlocation, opts.executables)
@@ -49,8 +55,8 @@ if opts.force:
for build_file in existing_build_files: for build_file in existing_build_files:
build_file.unlink() build_file.unlink()
print("running gazelle") print("running gazelle", gazelle, go_extractor_dir)
subprocess.check_call([gazelle]) subprocess.check_call([gazelle, "go/extractor"], cwd=workspace_dir)
# we want to stamp all newly generated `BUILD.bazel` files with a header # we want to stamp all newly generated `BUILD.bazel` files with a header
build_files_to_update = set(go_extractor_dir.glob("*/**/BUILD.bazel")) build_files_to_update = set(go_extractor_dir.glob("*/**/BUILD.bazel"))