hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #17110 from geoffw0/memfree

Browse Source 
C++: Improve cpp/memory-may-not-be-freed
This commit is contained in:
Geoffrey White
2024-07-31 15:59:42 +01:00
committed by GitHub
parent 06a4f907ef c172b946a1
commit 20672acb74
5 changed files with 84 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/Critical/MemoryMayNotBeFreed.ql
View File

@@ -39,7 +39,7 @@ predicate allocCallOrIndirect(Expr e) {
allocCallOrIndirect(rtn.getExpr())
or
// return variable assigned with alloc
exists(Variable v |
exists(StackVariable v |
v = rtn.getExpr().(VariableAccess).getTarget() and
allocCallOrIndirect(v.getAnAssignedValue()) and
not assignedToFieldOrGlobal(v, _)

4
cpp/ql/src/change-notes/2024-07-31-memory-may-not-be-freed.md Normal file
View File

@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Fixed false positives in the `cpp/memory-may-not-be-freed` ("Memory may not be freed") query involving class methods that returned an allocated field of that class being misidentified as allocators.