Java: Add isNotEmpty to NullGuards

2026-02-28 21:03:50 +01:00 · 2019-07-05 12:41:46 +01:00
parent a0dc84010a
commit 204a28df94
1 changed files with 8 additions and 0 deletions
--- a/java/ql/src/semmle/code/java/dataflow/NullGuards.qll
+++ b/java/ql/src/semmle/code/java/dataflow/NullGuards.qll
@@ -120,6 +120,14 @@ predicate nullCheckMethod(Method m, boolean branch, boolean isnull) {
  m.hasName("isBlank") and
  branch = false and
  isnull = false
+  or
+  (
+    m.getDeclaringType().hasQualifiedName("org.apache.commons.collections4", "CollectionUtils") or
+    m.getDeclaringType().hasQualifiedName("org.apache.commons.collections", "CollectionUtils")
+  ) and
+  m.hasName("isNotEmpty") and
+  branch = true and
+  isnull = false
 }

 /**