hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: address docstring review comments

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-11-12 10:03:08 +01:00
parent bd2fc33621
commit 2033bf81cc
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/Declarations/DeadStoreOfProperty.ql
View File

@@ -13,7 +13,7 @@ import Expressions.DOMProperties
import DeadStore
/**
* Holds if `assign` definitely assigns property `name` of `base`.
* Holds if `write` writes to property `name` of `base`, and `base` is the only base object of `write`.
*/
predicate unambiguousPropWrite(DataFlow::SourceNode base, string name, DataFlow::PropWrite write) {
write = base.getAPropertyWrite(name) and
@@ -83,7 +83,7 @@ predicate maybeAccessesAssignedPropInBlock(string name, DataFlow::PropWrite assi
}
/**
* Holds if `assign1` and `assign2` both assign property `name`, and the assigned property may be accessed between the two assignments.
* Holds if `assign1` and `assign2` both assign property `name`, and the assigned property is not accessed between the two assignments.
*/
bindingset[name]
predicate noPropAccessBetween(string name, DataFlow::PropWrite assign1, DataFlow::PropWrite assign2) {