hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Accept some less obvious alerts

Browse Source 
These are listed in a function called 'good' but it's difficult to say in isolation whether they should be flagged or not. Accepting the changes as they seem reasonable.
This commit is contained in:
Asger F
2025-02-12 14:12:04 +01:00
parent f395651807
commit 1f3c49638b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/test/query-tests/Security/CWE-116/IncompleteSanitization/tst.js
View File

@@ -126,18 +126,18 @@ function good11(s) {
return s.replace("%d", "42");
}
function good12(s) {
function goodOrBad12(s) {
s.replace('[', '').replace(']', '');
s.replace('(', '').replace(')', '');
s.replace('{', '').replace('}', '');
s.replace('<', '').replace('>', ''); // too common as a bad HTML sanitizer
s.replace('<', '').replace('>', ''); // $ Alert[js/incomplete-sanitization]
s.replace('[', '\\[').replace(']', '\\]');
s.replace('{', '\\{').replace('}', '\\}');
s.replace('[', '\\[').replace(']', '\\]'); // $ Alert[js/incomplete-sanitization]
s.replace('{', '\\{').replace('}', '\\}'); // $ Alert[js/incomplete-sanitization]
s = s.replace('[', '');
s = s.replace(']', '');
s.replace(/{/, '').replace(/}/, ''); // should have used a string literal if a single replacement was intended
s.replace(/{/, '').replace(/}/, ''); // $ Alert[js/incomplete-sanitization] - should have used a string literal if a single replacement was intended
s.replace(']', '').replace('[', ''); // $ Alert[js/incomplete-sanitization] - probably OK, but still flagged
}