hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

simplify by using hasQualifiedName

Browse Source
This commit is contained in:
Stephan Brandauer
2023-05-10 10:49:27 +02:00
parent f43edb8046
commit 1e5c9e8a58
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
java/ql/src/Telemetry/AutomodelFrameworkModeCharacteristics.qll
View File

@@ -79,30 +79,23 @@ module FrameworkCandidatesImpl implements SharedCharacteristics::CandidateSig {
}
predicate isSink(Endpoint e, string kind) {
exists(
string package, string type, boolean subtypes, string name, string signature, string ext,
string input
|
sinkSpec(e, package, type, subtypes, name, signature, ext, input) and
ExternalFlow::sinkModel(package, type, subtypes, name, [signature, ""], ext, input, kind, _)
exists(string package, string type, string name, string signature, string ext, string input |
sinkSpec(e, package, type, name, signature, ext, input) and
ExternalFlow::sinkModel(package, type, _, name, [signature, ""], ext, input, kind, _)
)
}
predicate isNeutral(Endpoint e) {
exists(string package, string type, string name, string signature |
sinkSpec(e, package, type, _, name, signature, _, _) and
sinkSpec(e, package, type, name, signature, _, _) and
ExternalFlow::neutralModel(package, type, name, [signature, ""], _)
)
}
additional predicate sinkSpec(
Endpoint e, string package, string type, boolean subtypes, string name, string signature,
string ext, string input
Endpoint e, string package, string type, string name, string signature, string ext, string input
) {
package = FrameworkCandidatesImpl::getCallable(e).getDeclaringType().getPackage().toString() and
type = FrameworkCandidatesImpl::getCallable(e).getDeclaringType().getName() and
subtypes = false and
name = FrameworkCandidatesImpl::getCallable(e).getName() and
FrameworkCandidatesImpl::getCallable(e).hasQualifiedName(package, type, name) and
signature = ExternalFlow::paramsString(getCallable(e)) and
ext = "" and
exists(int paramIdx | e.isParameterOf(_, paramIdx) | input = "Argument[" + paramIdx + "]")