hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix all other implicit-this warnings introduced by the acronym patch

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2022-03-11 13:22:07 +01:00
parent 2e2970128e
commit 1e365611fc
23 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
View File

@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
final Language::AST getAst() { result = Construction::getInstructionAst(this) } final Language::AST getAst() { result = Construction::getInstructionAst(this) }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated Language::AST getAST() { result = getAst() } deprecated Language::AST getAST() { result = this.getAst() }
/** /**
* Gets the location of the source code for this instruction. * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() } final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
/** DEPRECATED: Alias for getAstVariable */ /** DEPRECATED: Alias for getAstVariable */
deprecated Language::Variable getASTVariable() { result = getAstVariable() } deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
} }
/** /**

4
cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/Instruction.qll
View File

@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
final Language::AST getAst() { result = Construction::getInstructionAst(this) } final Language::AST getAst() { result = Construction::getInstructionAst(this) }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated Language::AST getAST() { result = getAst() } deprecated Language::AST getAST() { result = this.getAst() }
/** /**
* Gets the location of the source code for this instruction. * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() } final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
/** DEPRECATED: Alias for getAstVariable */ /** DEPRECATED: Alias for getAstVariable */
deprecated Language::Variable getASTVariable() { result = getAstVariable() } deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
} }
/** /**

2
cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll
View File

@@ -77,7 +77,7 @@ abstract class TranslatedExpr extends TranslatedElement {
final override Locatable getAst() { result = expr } final override Locatable getAst() { result = expr }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Locatable getAST() { result = getAst() } deprecated override Locatable getAST() { result = this.getAst() }
final override Function getFunction() { result = expr.getEnclosingFunction() } final override Function getFunction() { result = expr.getEnclosingFunction() }

4
cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
View File

@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
final Language::AST getAst() { result = Construction::getInstructionAst(this) } final Language::AST getAst() { result = Construction::getInstructionAst(this) }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated Language::AST getAST() { result = getAst() } deprecated Language::AST getAST() { result = this.getAst() }
/** /**
* Gets the location of the source code for this instruction. * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() } final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
/** DEPRECATED: Alias for getAstVariable */ /** DEPRECATED: Alias for getAstVariable */
deprecated Language::Variable getASTVariable() { result = getAstVariable() } deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
} }
/** /**

4
csharp/ql/src/experimental/ir/implementation/raw/Instruction.qll
View File

@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
final Language::AST getAst() { result = Construction::getInstructionAst(this) } final Language::AST getAst() { result = Construction::getInstructionAst(this) }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated Language::AST getAST() { result = getAst() } deprecated Language::AST getAST() { result = this.getAst() }
/** /**
* Gets the location of the source code for this instruction. * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() } final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
/** DEPRECATED: Alias for getAstVariable */ /** DEPRECATED: Alias for getAstVariable */
deprecated Language::Variable getASTVariable() { result = getAstVariable() } deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
} }
/** /**

2
csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedCondition.qll
View File

@@ -18,7 +18,7 @@ abstract class TranslatedCondition extends ConditionBase {
final override Language::AST getAst() { result = expr } final override Language::AST getAst() { result = expr }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
final Expr getExpr() { result = expr } final Expr getExpr() { result = expr }

2
csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedDeclaration.qll
View File

@@ -32,7 +32,7 @@ abstract class TranslatedLocalDeclaration extends TranslatedElement, TTranslated
final override Language::AST getAst() { result = expr } final override Language::AST getAst() { result = expr }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
} }
/** /**

2
csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedElement.qll
View File

@@ -368,7 +368,7 @@ abstract class TranslatedElement extends TTranslatedElement {
abstract Language::AST getAst(); abstract Language::AST getAst();
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated Language::AST getAST() { result = getAst() } deprecated Language::AST getAST() { result = this.getAst() }
/** /**
* Get the first instruction to be executed in the evaluation of this element. * Get the first instruction to be executed in the evaluation of this element.

2
csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedExpr.qll
View File

@@ -65,7 +65,7 @@ abstract class TranslatedExpr extends TranslatedExprBase {
final override Language::AST getAst() { result = expr } final override Language::AST getAst() { result = expr }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
final override Callable getFunction() { result = expr.getEnclosingCallable() } final override Callable getFunction() { result = expr.getEnclosingCallable() }

4
csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedFunction.qll
View File

@@ -31,7 +31,7 @@ class TranslatedFunction extends TranslatedElement, TTranslatedFunction {
final override Language::AST getAst() { result = callable } final override Language::AST getAst() { result = callable }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
/** /**
* Gets the function being translated. * Gets the function being translated.
@@ -288,7 +288,7 @@ class TranslatedParameter extends TranslatedElement, TTranslatedParameter {
final override Language::AST getAst() { result = param } final override Language::AST getAst() { result = param }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
final override Callable getFunction() { result = param.getCallable() } final override Callable getFunction() { result = param.getCallable() }

6
csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedInitialization.qll
View File

@@ -54,7 +54,7 @@ abstract class TranslatedInitialization extends TranslatedElement, TTranslatedIn
final override Language::AST getAst() { result = expr } final override Language::AST getAst() { result = expr }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
/** /**
* Gets the expression that is doing the initialization. * Gets the expression that is doing the initialization.
@@ -212,7 +212,7 @@ abstract class TranslatedElementInitialization extends TranslatedElement {
final override Language::AST getAst() { result = initList } final override Language::AST getAst() { result = initList }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
final override Callable getFunction() { result = initList.getEnclosingCallable() } final override Callable getFunction() { result = initList.getEnclosingCallable() }
@@ -319,7 +319,7 @@ abstract class TranslatedConstructorCallFromConstructor extends TranslatedElemen
final override Language::AST getAst() { result = call } final override Language::AST getAst() { result = call }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
final override TranslatedElement getChild(int id) { final override TranslatedElement getChild(int id) {
id = 0 and result = this.getConstructorCall() id = 0 and result = this.getConstructorCall()

2
csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedStmt.qll
View File

@@ -27,7 +27,7 @@ abstract class TranslatedStmt extends TranslatedElement, TTranslatedStmt {
final override Language::AST getAst() { result = stmt } final override Language::AST getAst() { result = stmt }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated override Language::AST getAST() { result = getAst() } deprecated override Language::AST getAST() { result = this.getAst() }
final override Callable getFunction() { result = stmt.getEnclosingCallable() } final override Callable getFunction() { result = stmt.getEnclosingCallable() }
} }

4
csharp/ql/src/experimental/ir/implementation/unaliased_ssa/Instruction.qll
View File

@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
final Language::AST getAst() { result = Construction::getInstructionAst(this) } final Language::AST getAst() { result = Construction::getInstructionAst(this) }
/** DEPRECATED: Alias for getAst */ /** DEPRECATED: Alias for getAst */
deprecated Language::AST getAST() { result = getAst() } deprecated Language::AST getAST() { result = this.getAst() }
/** /**
* Gets the location of the source code for this instruction. * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() } final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
/** DEPRECATED: Alias for getAstVariable */ /** DEPRECATED: Alias for getAstVariable */
deprecated Language::Variable getASTVariable() { result = getAstVariable() } deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
} }
/** /**

2
java/ql/lib/semmle/code/java/Expr.qll
View File

@@ -1671,7 +1671,7 @@ class LValue extends VarAccess {
Expr getRhs() { exists(Assignment e | e.getDest() = this and e.getSource() = result) } Expr getRhs() { exists(Assignment e | e.getDest() = this and e.getSource() = result) }
/** DEPRECATED: Alias for getRhs */ /** DEPRECATED: Alias for getRhs */
deprecated Expr getRHS() { result = getRhs() } deprecated Expr getRHS() { result = this.getRhs() }
} }
/** /**

2
java/ql/lib/semmle/code/java/dataflow/SSA.qll
View File

@@ -929,7 +929,7 @@ class SsaVariable extends TSsaVariable {
} }
/** DEPRECATED: Alias for getCfgNode */ /** DEPRECATED: Alias for getCfgNode */
deprecated ControlFlowNode getCFGNode() { result = getCfgNode() } deprecated ControlFlowNode getCFGNode() { result = this.getCfgNode() }
/** Gets a textual representation of this SSA variable. */ /** Gets a textual representation of this SSA variable. */
string toString() { none() } string toString() { none() }

2
java/ql/lib/semmle/code/java/dataflow/internal/BaseSSA.qll
View File

@@ -483,7 +483,7 @@ class BaseSsaVariable extends TBaseSsaVariable {
} }
/** DEPRECATED: Alias for getCfgNode */ /** DEPRECATED: Alias for getCfgNode */
deprecated ControlFlowNode getCFGNode() { result = getCfgNode() } deprecated ControlFlowNode getCFGNode() { result = this.getCfgNode() }
string toString() { none() } string toString() { none() }

2
java/ql/lib/semmle/code/java/frameworks/spring/SpringFlex.qll
View File

@@ -59,7 +59,7 @@ class SpringRemotingDestinationClass extends Class {
/** DEPRECATED: Alias for getRemotingDestinationXml */ /** DEPRECATED: Alias for getRemotingDestinationXml */
deprecated SpringRemotingDestination getRemotingDestinationXML() { deprecated SpringRemotingDestination getRemotingDestinationXML() {
result = getRemotingDestinationXml() result = this.getRemotingDestinationXml()
} }
/** /**

2
javascript/ql/lib/semmle/javascript/NPM.qll
View File

@@ -291,7 +291,7 @@ class NpmPackage extends @folder {
PackageJson getPackageJson() { result = pkg } PackageJson getPackageJson() { result = pkg }
/** DEPRECATED: Alias for getPackageJson */ /** DEPRECATED: Alias for getPackageJson */
deprecated PackageJSON getPackageJSON() { result = getPackageJson() } deprecated PackageJSON getPackageJSON() { result = this.getPackageJson() }
/** Gets the name of this package. */ /** Gets the name of this package. */
string getPackageName() { result = this.getPackageJson().getPackageName() } string getPackageName() { result = this.getPackageJson().getPackageName() }

4
javascript/ql/lib/semmle/javascript/PrintAst.qll
View File

@@ -405,7 +405,7 @@ private module PrintJavaScript {
JsxElement getJsxElement() { result = n } JsxElement getJsxElement() { result = n }
/** DEPRECATED: Alias for getJsxElement */ /** DEPRECATED: Alias for getJsxElement */
deprecated JSXElement getJSXElement() { result = getJsxElement() } deprecated JSXElement getJSXElement() { result = this.getJsxElement() }
override PrintAstNode getChild(int childIndex) { override PrintAstNode getChild(int childIndex) {
result.(ElementNode).getElement() = n.getAttribute(childIndex) result.(ElementNode).getElement() = n.getAttribute(childIndex)
@@ -431,7 +431,7 @@ private module PrintJavaScript {
JsxNode getJsxNode() { result = n } JsxNode getJsxNode() { result = n }
/** DEPRECATED: Alias for getJsxNode */ /** DEPRECATED: Alias for getJsxNode */
deprecated JSXNode getJSXNode() { result = getJsxNode() } deprecated JSXNode getJSXNode() { result = this.getJsxNode() }
override PrintAstNode getChild(int childIndex) { override PrintAstNode getChild(int childIndex) {
result.(ElementNode).getElement() = n.getBodyElement(childIndex) result.(ElementNode).getElement() = n.getBodyElement(childIndex)

6
javascript/ql/lib/semmle/javascript/dependencies/Dependencies.qll
View File

@@ -40,7 +40,7 @@ abstract class NpmDependency extends Dependency {
abstract string getNpmPackageName(); abstract string getNpmPackageName();
/** DEPRECATED: Alias for getNpmPackageName */ /** DEPRECATED: Alias for getNpmPackageName */
deprecated string getNPMPackageName() { result = getNpmPackageName() } deprecated string getNPMPackageName() { result = this.getNpmPackageName() }
/** Gets the version of the NPM package this module belongs to. */ /** Gets the version of the NPM package this module belongs to. */
abstract string getVersion(); abstract string getVersion();
@@ -106,7 +106,7 @@ class BundledNpmDependency extends NpmDependency {
override string getNpmPackageName() { result = this.getPackageJson().getPackageName() } override string getNpmPackageName() { result = this.getPackageJson().getPackageName() }
/** DEPRECATED: Alias for getNpmPackageName */ /** DEPRECATED: Alias for getNpmPackageName */
deprecated override string getNPMPackageName() { result = getNpmPackageName() } deprecated override string getNPMPackageName() { result = this.getNpmPackageName() }
override string getVersion() { result = this.getPackageJson().getVersion() } override string getVersion() { result = this.getPackageJson().getVersion() }
@@ -140,7 +140,7 @@ class ExternalNpmDependency extends NpmDependency {
} }
/** DEPRECATED: Alias for getNpmPackageName */ /** DEPRECATED: Alias for getNpmPackageName */
deprecated override string getNPMPackageName() { result = getNpmPackageName() } deprecated override string getNPMPackageName() { result = this.getNpmPackageName() }
private string getVersionNumber() { private string getVersionNumber() {
exists(string versionRange | versionRange = this.(JsonString).getValue() | exists(string versionRange | versionRange = this.(JsonString).getValue() |

8
javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll
View File

@@ -139,7 +139,7 @@ abstract class FrameworkLibraryWithUrlRegex extends FrameworkLibrary {
abstract string getAUrlRegex(); abstract string getAUrlRegex();
/** DEPRECATED: Alias for getAUrlRegex */ /** DEPRECATED: Alias for getAUrlRegex */
deprecated string getAURLRegex() { result = getAUrlRegex() } deprecated string getAURLRegex() { result = this.getAUrlRegex() }
} }
/** DEPRECATED: Alias for FrameworkLibraryWithUrlRegex */ /** DEPRECATED: Alias for FrameworkLibraryWithUrlRegex */
@@ -177,7 +177,7 @@ abstract class FrameworkLibraryWithGenericUrl extends FrameworkLibraryWithUrlReg
} }
/** DEPRECATED: Alias for getAUrlRegex */ /** DEPRECATED: Alias for getAUrlRegex */
deprecated override string getAURLRegex() { result = getAUrlRegex() } deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
} }
/** DEPRECATED: Alias for FrameworkLibraryWithGenericUrl */ /** DEPRECATED: Alias for FrameworkLibraryWithGenericUrl */
@@ -950,7 +950,7 @@ private class ApplicationInsights extends FrameworkLibraryWithUrlRegex {
override string getAUrlRegex() { result = ".*(?:^|/)ai\\.(" + semverRegex() + ")-build\\d+\\.js" } override string getAUrlRegex() { result = ".*(?:^|/)ai\\.(" + semverRegex() + ")-build\\d+\\.js" }
/** DEPRECATED: Alias for getAUrlRegex */ /** DEPRECATED: Alias for getAUrlRegex */
deprecated override string getAURLRegex() { result = getAUrlRegex() } deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
} }
/** /**
@@ -971,7 +971,7 @@ private class TwitterTextClassic extends FrameworkLibraryWithUrlRegex {
override string getAUrlRegex() { result = ".*(?:^|/)twitter_text" + variantRegex() + "\\.js" } override string getAUrlRegex() { result = ".*(?:^|/)twitter_text" + variantRegex() + "\\.js" }
/** DEPRECATED: Alias for getAUrlRegex */ /** DEPRECATED: Alias for getAUrlRegex */
deprecated override string getAURLRegex() { result = getAUrlRegex() } deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
} }
/** /**

2
javascript/ql/lib/semmle/javascript/frameworks/Markdown.qll
View File

@@ -24,7 +24,7 @@ module Markdown {
predicate preservesHtml() { any() } predicate preservesHtml() { any() }
/** DEPRECATED: Alias for preservesHtml */ /** DEPRECATED: Alias for preservesHtml */
deprecated predicate preservesHTML() { preservesHtml() } deprecated predicate preservesHTML() { this.preservesHtml() }
} }
private class MarkdownStepAsTaintStep extends TaintTracking::SharedTaintStep { private class MarkdownStepAsTaintStep extends TaintTracking::SharedTaintStep {

4
javascript/ql/lib/semmle/javascript/security/dataflow/DOM.qll
View File

@@ -101,7 +101,7 @@ class DomMethodCallExpr extends MethodCallExpr {
} }
/** DEPRECATED: Alias for interpretsArgumentsAsHtml */ /** DEPRECATED: Alias for interpretsArgumentsAsHtml */
deprecated predicate interpretsArgumentsAsHTML(Expr arg) { interpretsArgumentsAsHtml(arg) } deprecated predicate interpretsArgumentsAsHTML(Expr arg) { this.interpretsArgumentsAsHtml(arg) }
} }
/** /**
@@ -124,7 +124,7 @@ class DomPropWriteNode extends Assignment {
} }
/** DEPRECATED: Alias for interpretsValueAsHtml */ /** DEPRECATED: Alias for interpretsValueAsHtml */
deprecated predicate interpretsValueAsHTML() { interpretsValueAsHtml() } deprecated predicate interpretsValueAsHTML() { this.interpretsValueAsHtml() }
/** /**
* Holds if the assigned value is interpreted as JavaScript via javascript: protocol. * Holds if the assigned value is interpreted as JavaScript via javascript: protocol.