hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Refine PasswordInConfigurationFile to avoid FPs.

Browse Source 
We now exclude passwords that look like they might be filled in via
templating or shell substitution.
This commit is contained in:
Max Schaefer
2019-04-15 12:00:54 +01:00
parent ae6c768db8
commit 1d5bb97121
3 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
javascript/ql/src/Security/CWE-313/PasswordInConfigurationFile.ql
View File

@@ -45,11 +45,14 @@ from string key, string val, Locatable valElement
where
config(key, val, valElement) and
val != "" and
// exclude possible templates
not val.regexpMatch(Templating::getDelimiterMatchingRegexp()) and
(
key.toLowerCase() = "password"
or
key.toLowerCase() != "readme" and
val.regexpMatch("(?is).*password\\s*=(?!\\s*;).*")
// look for `password=...`, but exclude `password=;` and `password="$(...)"`
val.regexpMatch("(?is).*password\\s*=(?!\\s*;)(?!\"?[$`]).*")
) and
not exclude(valElement.getFile())
select valElement, "Avoid plaintext passwords in configuration files."