hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Address some review comments

Browse Source
This commit is contained in:
Asger Feldthaus
2021-02-15 12:24:17 +00:00
parent fd7cbd0c96
commit 1ce7c3448f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/semmle/javascript/frameworks/Redux.qll
View File

@@ -373,6 +373,7 @@ module Redux {
* }
* });
* export default slice.reducer;
* export const { actionType1, actionType2 } = slice.actions;
* ```
*/
private class CreateSliceReducer extends DelegatingReducer {
@@ -481,13 +482,12 @@ module Redux {
DataFlow::SourceNode ref() { result = ref(DataFlow::TypeTracker::end()) }
/**
* Holds if `successBlock` is executed when a check has determined that `action` originated from this action creator.
* Gets a block that is executed when a check has determined that `action` originated from this action creator.
*/
private ReachableBasicBlock getASuccessfulTypeCheckBlock(DataFlow::SourceNode action) {
action = getAnUntypedActionInReducer() and
result = getASuccessfulTypeCheckBlock(action, getTypeTag())
or
// and ProgramSlicing::areFilesInSameReduxApp(result.getFile(), this.getFile()) -- TODO delete?
// some action creators implement a .match method for this purpose
exists(ConditionGuardNode guard, DataFlow::CallNode call |
call = ref().getAMethodCall("match") and