diff --git a/java/ql/lib/semmle/code/java/deadcode/EntryPoints.qll b/java/ql/lib/semmle/code/java/deadcode/EntryPoints.qll index 0f4d493b06e..9945414745e 100644 --- a/java/ql/lib/semmle/code/java/deadcode/EntryPoints.qll +++ b/java/ql/lib/semmle/code/java/deadcode/EntryPoints.qll @@ -262,7 +262,7 @@ class ManagedBeanImplEntryPoint extends EntryPoint, RegisteredManagedBeanImpl { // Find the method that will be called for each method on each managed bean that this class // implements. this.inherits(result) and - result.overrides(this.getAnImplementedManagedBean().getAMethod()) + result.overrides+(this.getAnImplementedManagedBean().getAMethod()) } } diff --git a/java/ql/lib/semmle/code/java/deadcode/StrutsEntryPoints.qll b/java/ql/lib/semmle/code/java/deadcode/StrutsEntryPoints.qll index 953fe6f93ef..28306895e07 100644 --- a/java/ql/lib/semmle/code/java/deadcode/StrutsEntryPoints.qll +++ b/java/ql/lib/semmle/code/java/deadcode/StrutsEntryPoints.qll @@ -19,7 +19,7 @@ class Struts1ActionEntryPoint extends EntryPoint, Class { exists(Method methodFromAction | methodFromAction.getDeclaringType().hasQualifiedName("org.apache.struts.action", "Action") | - result.(Method).overrides(methodFromAction) + result.(Method).overrides+(methodFromAction) ) or this.getASupertype*().hasQualifiedName("org.apache.struts.actions", "DispatchAction") and diff --git a/java/ql/lib/semmle/code/java/frameworks/Thrift.qll b/java/ql/lib/semmle/code/java/frameworks/Thrift.qll index 9b2e2fcd5a2..bf826cfe47e 100644 --- a/java/ql/lib/semmle/code/java/frameworks/Thrift.qll +++ b/java/ql/lib/semmle/code/java/frameworks/Thrift.qll @@ -27,7 +27,7 @@ class ThriftIface extends Interface { Method getAnImplementingMethod() { result.getDeclaringType().(Class).getASupertype+() = this and - result.overrides(this.getAMethod()) and + result.overrides+(this.getAMethod()) and not result.getFile() = this.getFile() } } diff --git a/java/ql/lib/semmle/code/java/frameworks/javaee/ejb/EJB.qll b/java/ql/lib/semmle/code/java/frameworks/javaee/ejb/EJB.qll index 8d200a98c54..ccdea7a25b2 100644 --- a/java/ql/lib/semmle/code/java/frameworks/javaee/ejb/EJB.qll +++ b/java/ql/lib/semmle/code/java/frameworks/javaee/ejb/EJB.qll @@ -572,7 +572,7 @@ class RemoteInterface extends Interface { * abstract methods or overriding within an interface hierarchy. */ Method getARemoteMethodImplementationChecked() { - result.overrides(this.getARemoteMethod()) and + result.overrides+(this.getARemoteMethod()) and exists(result.getBody()) } diff --git a/java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql b/java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql index b6518ba9bdb..966762326b6 100644 --- a/java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql +++ b/java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql @@ -54,7 +54,6 @@ where sup.isSynchronized() and not sub.isSynchronized() and not delegatingOverride(sub, sup) and - not exists(Method mid | sub.overrides(mid) and mid.overrides(sup)) and supSrc = sup.getDeclaringType().getSourceDeclaration() select sub, "Method '" + sub.getName() + "' overrides a synchronized method in $@ but is not synchronized.", diff --git a/java/ql/src/Likely Bugs/Inheritance/NoNonFinalInConstructor.ql b/java/ql/src/Likely Bugs/Inheritance/NoNonFinalInConstructor.ql index bc37d39c1b2..990bebe3f57 100644 --- a/java/ql/src/Likely Bugs/Inheritance/NoNonFinalInConstructor.ql +++ b/java/ql/src/Likely Bugs/Inheritance/NoNonFinalInConstructor.ql @@ -45,7 +45,7 @@ where // which is an access to the object being initialized, ... ma = unqualifiedCallToNonAbstractMethod(c, m) and // ... there exists an overriding method in a subtype, - n.overrides(m) and + n.overrides+(m) and n.getDeclaringType().getASupertype+() = c.getDeclaringType() and // ... the method is in a supertype of c, m.getDeclaringType() = c.getDeclaringType().getASupertype*() and diff --git a/java/ql/test/library-tests/overrides/ConstructedOverrides2.expected b/java/ql/test/library-tests/overrides/ConstructedOverrides2.expected index da4d640bf46..af58fbd82e0 100644 --- a/java/ql/test/library-tests/overrides/ConstructedOverrides2.expected +++ b/java/ql/test/library-tests/overrides/ConstructedOverrides2.expected @@ -3,4 +3,3 @@ | ConstructedOverrides.java:17:7:17:9 | Sub | usedGeneric(U, String) | Super.class:0:0:0:0 | Super | usedGeneric(U, String) | | ConstructedOverrides.java:23:7:23:10 | Sub2 | unusedGeneric(V, String) | Super.class:0:0:0:0 | Super | unusedGeneric(U, String) | | ConstructedOverrides.java:23:7:23:10 | Sub2 | usedGeneric(V, String) | ConstructedOverrides.java:17:7:17:9 | Sub | usedGeneric(U, String) | -| ConstructedOverrides.java:23:7:23:10 | Sub2 | usedGeneric(V, String) | Super.class:0:0:0:0 | Super | usedGeneric(U, String) |