hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

FIXME already fixed

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2023-09-13 13:46:21 +02:00
parent 5e98ff48ff
commit 1c43d11c54
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
python/ql/src/meta/ClassHierarchy/Find.ql
View File

@@ -13,14 +13,6 @@ private import semmle.python.frameworks.FastApi
private import semmle.python.frameworks.Django
import semmle.python.frameworks.data.internal.ApiGraphModelsExtensions as Extensions
// FIXME: I think the implementation below for `getAlreadyModeledClass` is wrong, since
// it uses `.getASubclass*()` for flask/fastAPI (and initially also Django, I just fixed
// it for django while discovering this problem). Basically, I fear that it if library
// defines class A and B, where B is a subclass of A, the automated modeling might only
// find B...
//
// I doesn't seem to be the case, which is probably why I didn't discover this, but on
// top of my head I can't really tell why.
class FlaskViewClasses extends FindSubclassesSpec {
FlaskViewClasses() { this = "flask.View~Subclass" }