hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add explanatory comments

Browse Source
This commit is contained in:
Owen Mansel-Chan
2021-08-12 14:51:49 +01:00
parent fe477ff989
commit 1c2476c6a1
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/ql/src/semmle/code/java/frameworks/apache/Collections.qll
View File

@@ -301,6 +301,7 @@ private class ApacheCollectionUtilsModel extends SummaryModelCsv {
";CollectionUtils;true;selectRejected;(Iterable,Predicate,Collection);;Argument[2];ReturnValue;value",
";CollectionUtils;true;subtract;;;Element of Argument[0];Element of ReturnValue;value",
";CollectionUtils;true;synchronizedCollection;;;Element of Argument[0];Element of ReturnValue;value",
// Note that `CollectionUtils.transformingCollection` does not transform existing list elements
";CollectionUtils;true;transformingCollection;;;Element of Argument[0];Element of ReturnValue;value",
";CollectionUtils;true;union;;;Element of Argument[0];Element of ReturnValue;value",
";CollectionUtils;true;union;;;Element of Argument[1];Element of ReturnValue;value",
@@ -323,6 +324,7 @@ private class ApacheListUtilsModel extends SummaryModelCsv {
";ListUtils;true;fixedSizeList;;;Element of Argument[0];Element of ReturnValue;value",
";ListUtils;true;intersection;;;Element of Argument[0];Element of ReturnValue;value",
";ListUtils;true;intersection;;;Element of Argument[1];Element of ReturnValue;value",
// Note that `ListUtils.lazyList` does not transform existing list elements
";ListUtils;true;lazyList;;;Element of Argument[0];Element of ReturnValue;value",
";ListUtils;true;longestCommonSubsequence;(CharSequence,CharSequence);;Argument[0];ReturnValue;taint",
";ListUtils;true;longestCommonSubsequence;(CharSequence,CharSequence);;Argument[1];ReturnValue;taint",
@@ -340,6 +342,7 @@ private class ApacheListUtilsModel extends SummaryModelCsv {
";ListUtils;true;sum;;;Element of Argument[0];Element of ReturnValue;value",
";ListUtils;true;sum;;;Element of Argument[1];Element of ReturnValue;value",
";ListUtils;true;synchronizedList;;;Element of Argument[0];Element of ReturnValue;value",
// Note that `ListUtils.transformedList` does not transform existing list elements
";ListUtils;true;transformedList;;;Element of Argument[0];Element of ReturnValue;value",
";ListUtils;true;union;;;Element of Argument[0];Element of ReturnValue;value",
";ListUtils;true;union;;;Element of Argument[1];Element of ReturnValue;value",

1
java/ql/test/library-tests/frameworks/apache-collections/test.ql
View File

@@ -9,6 +9,7 @@ class SummaryModelTest extends SummaryModelCsv {
row =
[
//"package;type;overrides;name;signature;ext;inputspec;outputspec;kind",
// This is temporarily modelled for the helper function newEnumerationWithElement, until the relevant package is modelled
"org.apache.commons.collections4.iterators;IteratorEnumeration;true;IteratorEnumeration;;;Element of Argument[0];Element of Argument[-1];value",
"generatedtest;Test;false;newRBWithMapValue;;;Argument[0];MapValue of ReturnValue;value",
"generatedtest;Test;false;newRBWithMapKey;;;Argument[0];MapKey of ReturnValue;value"