From 1a52398a291367f9f4217edf21aa9c97242ef5c9 Mon Sep 17 00:00:00 2001 From: Owen Mansel-Chan Date: Thu, 13 Feb 2025 21:50:47 +0000 Subject: [PATCH] Address review comments --- .../upgrade.properties | 4 ++-- go/ql/lib/semmle/go/Scopes.qll | 4 ++-- .../upgrade.properties | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/go/downgrades/b3da71c3ac204b557c86e9d9c26012360bdbdccb/upgrade.properties b/go/downgrades/b3da71c3ac204b557c86e9d9c26012360bdbdccb/upgrade.properties index 64da53384a5..73db35e7e1b 100644 --- a/go/downgrades/b3da71c3ac204b557c86e9d9c26012360bdbdccb/upgrade.properties +++ b/go/downgrades/b3da71c3ac204b557c86e9d9c26012360bdbdccb/upgrade.properties @@ -1,2 +1,2 @@ -description: -compatibility: full|backwards|partial|breaking +description: Rename @definedtype to @namedtype +compatibility: full diff --git a/go/ql/lib/semmle/go/Scopes.qll b/go/ql/lib/semmle/go/Scopes.qll index 0ca97acf86c..edea24c184f 100644 --- a/go/ql/lib/semmle/go/Scopes.qll +++ b/go/ql/lib/semmle/go/Scopes.qll @@ -195,8 +195,8 @@ class BuiltinEntity extends Entity, @builtinobject { } class PackageEntity extends Entity, @pkgobject { } /** - * A named type (predeclared types, defined types, type parameters and aliases - * which refer to those things). + * A named type: predeclared types, defined types, type parameters, and type + * aliases. */ class TypeEntity extends Entity, @typeobject { } diff --git a/go/ql/lib/upgrades/4bd57e093275e5e892dfb16b55ed4bd76ea662be/upgrade.properties b/go/ql/lib/upgrades/4bd57e093275e5e892dfb16b55ed4bd76ea662be/upgrade.properties index 64da53384a5..ca2da0c9fc7 100644 --- a/go/ql/lib/upgrades/4bd57e093275e5e892dfb16b55ed4bd76ea662be/upgrade.properties +++ b/go/ql/lib/upgrades/4bd57e093275e5e892dfb16b55ed4bd76ea662be/upgrade.properties @@ -1,2 +1,2 @@ -description: -compatibility: full|backwards|partial|breaking +description: Rename @namedtype to @definedtype +compatibility: full