hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 11:16:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

add JavaScript support for new private fields syntax

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2021-11-25 00:14:36 +01:00
parent d1a7feebc4
commit 19bbe6d276
9 changed files with 291 additions and 201 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
javascript/extractor/src/com/semmle/js/extractor/ASTExtractor.java
View File

@@ -847,8 +847,15 @@ public class ASTExtractor {
@Override
public Label visit(BinaryExpression nd, Context c) {
Label key = super.visit(nd, c);
visit(nd.getLeft(), key, 0, true);
if (nd.getOperator().equals("in") && nd.getLeft() instanceof Identifier && ((Identifier)nd.getLeft()).getName().startsWith("#")) {
// this happens with Ergonomic brand checks for Private Fields (see https://github.com/tc39/proposal-private-fields-in-in).
// it's the only case where private field identifiers are used not as a field.
visit(nd.getLeft(), key, 0, IdContext.LABEL, true);
} else {
visit(nd.getLeft(), key, 0, true);
}
visit(nd.getRight(), key, 1, true);
extractRegxpFromBinop(nd, c);
return key;
}