hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Allow imprecise matching for Kotlin -> Java method translation

Browse Source 
This allows the particular case of Collection.toArray(IntFunction<T>) to match, since both Java and Kotlin functions take an IntFunction<T> but they use different function-local type variables.

This would also allow toArray(Array<T>) to work similarly.
This commit is contained in:
Chris Smowton
2022-04-20 16:58:28 +01:00
parent 77056c9bff
commit 16af811b69
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt
View File

@@ -911,7 +911,10 @@ open class KotlinUsesExtractor(
decl is IrFunction && decl is IrFunction &&
decl.name == f.name && decl.name == f.name &&
decl.valueParameters.size == f.valueParameters.size && decl.valueParameters.size == f.valueParameters.size &&
decl.valueParameters.zip(f.valueParameters).all { p -> p.first.type == p.second.type } // Note matching by classifier not the whole type so that generic arguments are allowed to differ,
// as they always will for method type parameters occurring in parameter types (e.g. <T> toArray(T[] array)
// Differing only by nullability would also be insignificant if it came up.
decl.valueParameters.zip(f.valueParameters).all { p -> p.first.type.classifierOrNull == p.second.type.classifierOrNull }
} ?: } ?:
// Or if there is none, look for the only viable overload // Or if there is none, look for the only viable overload
javaClass.declarations.singleOrNull { decl -> javaClass.declarations.singleOrNull { decl ->