hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

[CPP-434] Remove references to underflow and subtraction.

Browse Source
This commit is contained in:
Ziemowit Laski
2019-10-02 12:32:11 -07:00
parent 8c6caf2b4e
commit 16411d1b6e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/src/Likely Bugs/Arithmetic/SignedOverflowCheck.ql
View File

@@ -21,10 +21,10 @@ where
ro.getAnOperand() = va2 and
va1.getTarget() = va2.getTarget() and
/*
* if the addition/subtraction (`bao`) has been promoted to a signed type,
* if the addition (`bao`) has been promoted to a signed type,
* then the other operand (`va2`) must have been likewise promoted and so
* have a signed comparison
*/
bao.getFullyConverted().getType().(IntegralType).isSigned()
select ro, "Testing for signed overflow/underflow may produce undefined results."
select ro, "Testing for signed overflow may produce undefined results."