hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 19:55:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Use TypeTrackingNode in new PEP249 modeling

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2021-08-17 12:03:40 +02:00
parent b649f5f38c
commit 15d483d56c
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/ql/src/semmle/python/frameworks/internal/PEP249Impl.qll
View File

@@ -61,7 +61,7 @@ module PEP249 {
}
/** Gets a reference to a database connection (following PEP 249). */
private DataFlow::LocalSourceNode instance(DataFlow::TypeTracker t) {
private DataFlow::TypeTrackingNode instance(DataFlow::TypeTracker t) {
t.start() and
result instanceof InstanceSource
or
@@ -94,7 +94,7 @@ module PEP249 {
abstract class InstanceSource extends DataFlow::LocalSourceNode { }
/** Gets a reference to a database cursor. */
private DataFlow::LocalSourceNode instance(DataFlow::TypeTracker t) {
private DataFlow::TypeTrackingNode instance(DataFlow::TypeTracker t) {
t.start() and
result instanceof InstanceSource
or
@@ -105,7 +105,7 @@ module PEP249 {
DataFlow::Node instance() { instance(DataFlow::TypeTracker::end()).flowsTo(result) }
/** Gets a reference to the `cursor` method on a database connection. */
private DataFlow::LocalSourceNode methodRef(DataFlow::TypeTracker t) {
private DataFlow::TypeTrackingNode methodRef(DataFlow::TypeTracker t) {
t.startInAttr("cursor") and
result = Connection::instance()
or
@@ -121,7 +121,7 @@ module PEP249 {
}
/** Gets a reference to a result of calling the `cursor` method on a database connection. */
private DataFlow::LocalSourceNode methodResult(DataFlow::TypeTracker t) {
private DataFlow::TypeTrackingNode methodResult(DataFlow::TypeTracker t) {
t.start() and
result.asCfgNode().(CallNode).getFunction() = methodRef().asCfgNode()
or
@@ -146,7 +146,7 @@ module PEP249 {
*
* See https://www.python.org/dev/peps/pep-0249/#id15.
*/
private DataFlow::LocalSourceNode execute(DataFlow::TypeTracker t) {
private DataFlow::TypeTrackingNode execute(DataFlow::TypeTracker t) {
t.startInAttr("execute") and
result in [Cursor::instance(), Connection::instance()]
or