hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: Remove jump-to-namespace

Browse Source
This commit is contained in:
Asger F
2019-05-22 13:45:08 +01:00
parent fe920ecfaa
commit 153e778f7f
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javascript/ql/src/definitions.ql
View File

@@ -123,7 +123,7 @@ predicate propertyLookup(Expr prop, ASTNode write, string kind) {
} }
/** /**
* Holds if `ref` is an identifier that refers to a type or namespace declared at `decl`. * Holds if `ref` is an identifier that refers to a type declared at `decl`.
*/ */
predicate typeLookup(ASTNode ref, ASTNode decl, string kind) { predicate typeLookup(ASTNode ref, ASTNode decl, string kind) {
exists(TypeAccess typeAccess | exists(TypeAccess typeAccess |
@@ -131,12 +131,6 @@ predicate typeLookup(ASTNode ref, ASTNode decl, string kind) {
decl = typeAccess.getTypeName().getADefinition() and decl = typeAccess.getTypeName().getADefinition() and
kind = "T" kind = "T"
) )
or
exists(NamespaceAccess namespaceAccess |
ref = namespaceAccess.getIdentifier() and
decl = namespaceAccess.getNamespace().getADefinition() and
kind = "T"
)
} }
/** /**

2
javascript/ql/test/query-tests/definitions/definitions.expected
View File

@@ -5,11 +5,9 @@
| client.ts:7:19:7:19 | C | tslib.ts:1:8:3:1 | class C {\\n m() {}\\n} | T | | client.ts:7:19:7:19 | C | tslib.ts:1:8:3:1 | class C {\\n m() {}\\n} | T |
| client.ts:8:10:8:10 | C | client.ts:3:1:5:1 | class C {\\n m() {}\\n} | T | | client.ts:8:10:8:10 | C | client.ts:3:1:5:1 | class C {\\n m() {}\\n} | T |
| client.ts:9:16:9:16 | C | client.ts:3:1:5:1 | class C {\\n m() {}\\n} | T | | client.ts:9:16:9:16 | C | client.ts:3:1:5:1 | class C {\\n m() {}\\n} | T |
| client.ts:10:14:10:14 | N | tslib.ts:5:8:9:1 | namespa ... }\\n }\\n} | T |
| client.ts:10:16:10:16 | C | tslib.ts:6:10:8:3 | class C ... {}\\n } | T | | client.ts:10:16:10:16 | C | tslib.ts:6:10:8:3 | class C ... {}\\n } | T |
| client.ts:13:25:13:25 | C | client.ts:3:1:5:1 | class C {\\n m() {}\\n} | T | | client.ts:13:25:13:25 | C | client.ts:3:1:5:1 | class C {\\n m() {}\\n} | T |
| client.ts:13:35:13:35 | C | tslib.ts:1:8:3:1 | class C {\\n m() {}\\n} | T | | client.ts:13:35:13:35 | C | tslib.ts:1:8:3:1 | class C {\\n m() {}\\n} | T |
| client.ts:13:45:13:45 | N | tslib.ts:5:8:9:1 | namespa ... }\\n }\\n} | T |
| client.ts:13:47:13:47 | C | tslib.ts:6:10:8:3 | class C ... {}\\n } | T | | client.ts:13:47:13:47 | C | tslib.ts:6:10:8:3 | class C ... {}\\n } | T |
| client.ts:14:3:14:3 | x | client.ts:13:22:13:22 | x | V | | client.ts:14:3:14:3 | x | client.ts:13:22:13:22 | x | V |
| client.ts:14:5:14:5 | m | client.ts:4:3:4:8 | m() {} | M | | client.ts:14:5:14:5 | m | client.ts:4:3:4:8 | m() {} | M |