hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 19:55:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update DangerousUseOfExceptionBlocks.cpp

Browse Source
This commit is contained in:
ihsinme
2022-03-21 09:52:14 +03:00
committed by GitHub
parent 22cf3f7b20
commit 151c93f502
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
cpp/ql/src/experimental/Security/CWE/CWE-476/DangerousUseOfExceptionBlocks.cpp
View File

@@ -1,30 +1,30 @@
...
try {
if (checkValue) throw exception();
valData->bufMyData = new myData*[valData->sizeInt];
bufMyData = new myData*[sizeInt];
}
catch (...)
{
for (size_t i = 0; i < valData->sizeInt; i++)
for (size_t i = 0; i < sizeInt; i++)
{
delete[] valData->bufMyData[i]->buffer; // BAD
delete valData->bufMyData[i];
delete[] bufMyData[i]->buffer; // BAD
delete bufMyData[i];
}
...
try {
if (checkValue) throw exception();
valData->bufMyData = new myData*[valData->sizeInt];
bufMyData = new myData*[sizeInt];
}
catch (...)
{
for (size_t i = 0; i < valData->sizeInt; i++)
for (size_t i = 0; i < sizeInt; i++)
{
if(valData->bufMyData[i])
if(bufMyData[i])
{
delete[] valData->bufMyData[i]->buffer; // GOOD
delete valData->bufMyData[i];
delete[] bufMyData[i]->buffer; // GOOD
delete bufMyData[i];
}
}