From 14b75a968bad11f70cde492724ecfed09cd0df15 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Fri, 13 Jun 2025 14:09:49 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> --- .../ql/src/queries/security/CWE-825/AccessAfterLifetime.qhelp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/ql/src/queries/security/CWE-825/AccessAfterLifetime.qhelp b/rust/ql/src/queries/security/CWE-825/AccessAfterLifetime.qhelp index 41d62af44e3..fe5dd64a270 100644 --- a/rust/ql/src/queries/security/CWE-825/AccessAfterLifetime.qhelp +++ b/rust/ql/src/queries/security/CWE-825/AccessAfterLifetime.qhelp @@ -6,7 +6,7 @@
Dereferencing a pointer after the lifetime of its target has ended causes undefined behavior. Memory -may be corrupted causing the program to crash or behave incorrectly, in some cases exposing the program +may be corrupted, causing the program to crash or behave incorrectly, in some cases exposing the program to potential attacks.
@@ -33,7 +33,7 @@ after that lifetime has ended, causing undefined behavior:
One way to fix this is to change the return type of the function from a pointer to a Box,
which ensures that the value it points to remains on the heap for the lifetime of the Box
-itself. Notice that there is no longer a need for an unsafe block as the code no longer
+itself. Note that there is no longer a need for an unsafe block as the code no longer
handles pointers directly: