hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 05:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Address review comments.

Browse Source
This commit is contained in:
Michael Nebel
2022-03-16 16:00:48 +01:00
parent ba67ea0445
commit 138eb485c6
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
csharp/ql/src/Language Abuse/MissedTernaryOpportunity.ql
View File

@@ -16,10 +16,6 @@ private Expr getAssignedExpr(Stmt stmt) {
result = stmt.stripSingletonBlocks().(ExprStmt).getExpr().(AssignExpr).getLValue()
}
private predicate ifStmt(IfStmt is) {
sameGvn(getAssignedExpr(is.getThen()), getAssignedExpr(is.getElse()))
}
from IfStmt is, string what
where
(
@@ -27,7 +23,7 @@ where
is.getElse().stripSingletonBlocks() instanceof ReturnStmt and
what = "return"
or
ifStmt(is) and
sameGvn(getAssignedExpr(is.getThen()), getAssignedExpr(is.getElse())) and
what = "write to the same variable"
) and
not exists(IfStmt other | is = other.getElse())