hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 16:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Adress review comments

Browse Source 
- make qldoc accurate
- fix ql4ql alert
This commit is contained in:
Rasmus Lerchedahl Petersen
2023-08-24 21:28:07 +02:00
parent d3c24ba110
commit 137f9e7234
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/ql/lib/semmle/python/regexp/internal/ParseRegExp.qll
View File

@@ -683,10 +683,8 @@ class RegExp extends Expr instanceof StrConst {
* Holds if a parse mode starts between `start` and `end`.
*/
private predicate flag_group_start(int start, int end) {
exists(int no_modes_end |
this.flag_group_start_no_modes(start, no_modes_end) and
end = max(int i | this.mode_character(start, i) | i + 1)
)
this.flag_group_start_no_modes(start, _) and
end = max(int i | this.mode_character(start, i) | i + 1)
}
/**
@@ -712,8 +710,8 @@ class RegExp extends Expr instanceof StrConst {
}
/**
* Holds if a parse mode group is between `start` and `end`, and includes the
* mode flag `c`. For example the following span, with mode flag `i`:
* Holds if a parse mode group includes the mode flag `c`.
* For example the following parse mode group, with mode flag `i`:
* ```
* (?i)
* ```