hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Apply suggestions from code review

Browse Source 
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
Co-authored-by: yoff <lerchedahl@gmail.com>
This commit is contained in:
Taus
2022-11-11 13:49:46 +01:00
committed by GitHub
parent 58754982ce
commit 131fc986b4
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/ql/lib/semmle/python/dataflow/new/internal/ImportResolution.qll
View File

@@ -35,10 +35,10 @@ private import semmle.python.dataflow.new.TypeTracker
* 1. If `foo` is a module, and `bar` is an attribute of `foo`, then `from foo import bar` imports * 1. If `foo` is a module, and `bar` is an attribute of `foo`, then `from foo import bar` imports
* the attribute `bar` into the current module (binding it to the name `bar`). * the attribute `bar` into the current module (binding it to the name `bar`).
* 2. If `foo` is a package, and `bar` is a submodule of `foo`, then `from foo import bar` first imports * 2. If `foo` is a package, and `bar` is a submodule of `foo`, then `from foo import bar` first imports
* `foo.bar`, and then attempts to locate the `bar` attribute again. In most cases, that attribute * `foo.bar`, and then reads the `bar` attribute on `foo`. In most cases, that attribute
* will then point to the `bar` submodule. * will then point to the `bar` submodule.
* *
* Now, when in comes to how these imports are represented in the AST, things get a bit complicated. * Now, when it comes to how these imports are represented in the AST, things get a bit complicated.
* First of all, both of the above forms of imports get mapped to the same kind of AST node: * First of all, both of the above forms of imports get mapped to the same kind of AST node:
* `Import`. An `Import` node has a sequence of names, each of which is an `Alias` node. This `Alias` * `Import`. An `Import` node has a sequence of names, each of which is an `Alias` node. This `Alias`
* node represents the `x as y` bit of each imported module. * node represents the `x as y` bit of each imported module.
@@ -230,7 +230,7 @@ module ImportResolution {
module_reexport(p, attr_name, m) module_reexport(p, attr_name, m)
) )
or or
// Submodules that are implicitly defined when importing via `from ... import ...` statements. // Submodules that are implicitly defined whith relative imports of the form `from .foo import ...`.
// In practice, we create a definition for each module in a package, even if it is not imported. // In practice, we create a definition for each module in a package, even if it is not imported.
exists(string submodule, Module package | exists(string submodule, Module package |
SsaSource::init_module_submodule_defn(result.asVar().getSourceVariable(), SsaSource::init_module_submodule_defn(result.asVar().getSourceVariable(),