hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 18:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: delete some FIXMEs that turned out fine

Browse Source
This commit is contained in:
Robert Marsh
2024-02-13 15:34:36 +00:00
parent b9785ea7b2
commit 128bc99f90
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedInitialization.qll
View File

@@ -1067,7 +1067,7 @@ class TranslatedConstructorBareInit extends TranslatedElement, TTranslatedConstr
result = this.getParent().getChildSuccessor(this, kind) result = this.getParent().getChildSuccessor(this, kind)
} }
override Instruction getALastInstructionInternal() { none() } // FIXME: does this need to be filled in? override Instruction getALastInstructionInternal() { none() }
override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) { override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {
none() none()

3
cpp/ql/lib/semmle/code/cpp/models/implementations/SmartPointer.qll
View File

@@ -181,7 +181,6 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu
* Gets the destructor associated with the base type of this smart pointer. * Gets the destructor associated with the base type of this smart pointer.
*/ */
private Destructor getBaseTypeDestructor() { private Destructor getBaseTypeDestructor() {
// TODO: Check if this is join ordered correctly.
result.getDeclaringType() = declaringType.getBaseType() result.getDeclaringType() = declaringType.getBaseType()
} }
@@ -222,4 +221,4 @@ private class SmartPtrDestructor extends Destructor, SideEffectFunction, AliasFu
// A destructor call does not have a return value // A destructor call does not have a return value
none() none()
} }
} }