hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments.

Browse Source
This commit is contained in:
Calum Grant
2021-10-19 16:30:54 +01:00
parent 5861fcf443
commit 112d408fb9
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/codeql/codeql-language-guides/basic-query-for-ruby-code.rst
View File

@@ -108,14 +108,12 @@ Browsing the results of our basic query shows that it could be improved. Among t
.. code-block:: ruby
if ...
...
elsif option == "-verbose"
if option == "-verbose"
# nothing to do - handled earlier
else
error "unrecognized option"
In this case, identifying the ``if`` statement with the empty ``then`` branch as redundant is a false positive. One solution to this is to modify the query to ignore empty ``then`` branches if the ``if`` statement has an ``else`` branch.
In this case, identifying the ``if`` statement with the empty ``then`` branch as redundant is a false positive. One solution to this is to modify the query to select ``if`` statements where both the ``then`` and ``else`` branches are missing.
To exclude ``if`` statements that have an ``else`` branch: