hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 17:23:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix two bugs found by @rdmarsh2

Browse Source 
Co-Authored-By: Robert Marsh <rdmarsh2@gmail.com>
This commit is contained in:
Jonas Jensen
2020-04-04 15:14:24 +02:00
parent 5822cd7b84
commit 108d5177b8
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/Security/CWE/CWE-134/UncontrolledFormatStringThroughGlobalVar.ql
View File

@@ -34,6 +34,6 @@ where
not taintedWithoutGlobals(arg) and not taintedWithoutGlobals(arg) and
taintedWithPath(userValue, arg, sourceNode, sinkNode) and taintedWithPath(userValue, arg, sourceNode, sinkNode) and
isUserInput(userValue, cause) isUserInput(userValue, cause)
select arg, select arg, sourceNode, sinkNode,
"The value of this argument may come from $@ and is being used as a formatting argument to " + "The value of this argument may come from $@ and is being used as a formatting argument to " +
printfFunction, userValue, cause printfFunction, userValue, cause

2
cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll
View File

@@ -489,7 +489,7 @@ module TaintedWithPath {
} }
} }
private class WrapPathNode extends PathNode, TPathNode { private class WrapPathNode extends PathNode, TWrapPathNode {
DataFlow3::PathNode inner() { this = TWrapPathNode(result) } DataFlow3::PathNode inner() { this = TWrapPathNode(result) }
override string toString() { result = this.inner().toString() } override string toString() { result = this.inner().toString() }