hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: cleanup for all HTTP::RouteHandlerCandidates

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-12-03 10:13:08 +01:00
parent 88c69e2c9c
commit 104eafec2f
4 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/semmle/javascript/frameworks/ConnectExpressShared.qll
View File

@@ -32,9 +32,7 @@ module ConnectExpressShared {
*
* For example, this could be the function `function(req, res, next){...}`.
*/
class RouteHandlerCandidate extends HTTP::RouteHandlerCandidate, DataFlow::FunctionNode {
override Function astNode;
class RouteHandlerCandidate extends HTTP::RouteHandlerCandidate {
RouteHandlerCandidate() {
exists (string request, string response, string next, string error |

4
javascript/ql/src/semmle/javascript/frameworks/Hapi.qll
View File

@@ -228,9 +228,7 @@ module Hapi {
*
* For example, this could be the function `function(request, h){...}`.
*/
class RouteHandlerCandidate extends HTTP::RouteHandlerCandidate, DataFlow::FunctionNode {
override Function astNode;
class RouteHandlerCandidate extends HTTP::RouteHandlerCandidate {
RouteHandlerCandidate() {
exists (string request, string responseToolkit |

4
javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
View File

@@ -597,9 +597,7 @@ module NodeJSLib {
*
* For example, this could be the function `function(req, res){...}`.
*/
class RouteHandlerCandidate extends HTTP::RouteHandlerCandidate, DataFlow::FunctionNode {
override Function astNode;
class RouteHandlerCandidate extends HTTP::RouteHandlerCandidate {
RouteHandlerCandidate() {
exists (string request, string response |

8
javascript/ql/src/semmle/javascript/heuristics/AdditionalRouteHandlers.qll
View File

@@ -8,7 +8,7 @@ import javascript
private import semmle.javascript.frameworks.ConnectExpressShared
/**
* Adds `NodeJSLib::RouteHandlerCandidate` to the extent of `NodeJSLib::RouteHandler`.
* Add `NodeJSLib::RouteHandlerCandidate` to the extent of `NodeJSLib::RouteHandler`.
*/
private class PromotedNodeJSLibCandidate extends NodeJSLib::RouteHandler, HTTP::Servers::StandardRouteHandler {
@@ -19,7 +19,7 @@ private class PromotedNodeJSLibCandidate extends NodeJSLib::RouteHandler, HTTP::
}
/**
* Adds `Hapi::RouteHandlerCandidate` to the extent of `Hapi::RouteHandler`.
* Add `Hapi::RouteHandlerCandidate` to the extent of `Hapi::RouteHandler`.
*/
private class PromotedHapiCandidate extends Hapi::RouteHandler, HTTP::Servers::StandardRouteHandler {
@@ -30,7 +30,7 @@ private class PromotedHapiCandidate extends Hapi::RouteHandler, HTTP::Servers::S
}
/**
* Adds `ConnectExpressShared::RouteHandlerCandidate` to the extent of `Express::RouteHandler`.
* Add `ConnectExpressShared::RouteHandlerCandidate` to the extent of `Express::RouteHandler`.
*/
private class PromotedExpressCandidate extends Express::RouteHandler, HTTP::Servers::StandardRouteHandler {
@@ -45,7 +45,7 @@ private class PromotedExpressCandidate extends Express::RouteHandler, HTTP::Serv
}
/**
* Adds `ConnectExpressShared::RouteHandlerCandidate` to the extent of `Connect::RouteHandler`.
* Add `ConnectExpressShared::RouteHandlerCandidate` to the extent of `Connect::RouteHandler`.
*/
private class PromotedConnectCandidate extends Connect::RouteHandler, HTTP::Servers::StandardRouteHandler {