hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6094 from hvitved/dataflow/consistency-compiler-too-smart

Browse Source 
Data flow: Workaround for too clever compiler in consistency queries
This commit is contained in:
Tom Hvitved
2021-06-17 10:23:31 +02:00
committed by GitHub
parent bcafe532ac cc383e0f6a
commit 0febf5a592
5 changed files with 35 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
python/ql/src/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll
View File

@@ -168,7 +168,13 @@ module Consistency {
msg = "ArgumentNode is missing PostUpdateNode."
}
query predicate postWithInFlow(PostUpdateNode n, string msg) {
// This predicate helps the compiler forget that in some languages
// it is impossible for a `PostUpdateNode` to be the target of
// `simpleLocalFlowStep`.
private predicate isPostUpdateNode(Node n) { n instanceof PostUpdateNode or none() }
query predicate postWithInFlow(Node n, string msg) {
isPostUpdateNode(n) and
simpleLocalFlowStep(_, n) and
msg = "PostUpdateNode should not be the target of local flow."
}