hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-20 08:53:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST: rename getExpr predicates to more meaningful names

Browse Source
This commit is contained in:
Arthur Baars
2021-02-25 10:11:29 +01:00
parent 1a73cf6cc4
commit 0f940349ba
6 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ql/src/codeql_ruby/ast/Call.qll
View File

@@ -164,7 +164,7 @@ class BlockArgument extends Expr, @block_argument {
* foo(&bar)
* ```
*/
final Expr getExpr() { result = range.getExpr() }
final Expr getValue() { result = range.getValue() }
}
/**
@@ -185,7 +185,7 @@ class SplatArgument extends Expr, @splat_argument {
* foo(*bar)
* ```
*/
final Expr getExpr() { result = range.getExpr() }
final Expr getValue() { result = range.getValue() }
}
/**
@@ -206,5 +206,5 @@ class HashSplatArgument extends Expr, @hash_splat_argument {
* foo(**bar)
* ```
*/
final Expr getExpr() { result = range.getExpr() }
final Expr getValue() { result = range.getValue() }
}

4
ql/src/codeql_ruby/ast/Control.qll
View File

@@ -151,7 +151,7 @@ class IfModifierExpr extends ConditionalExpr, @if_modifier {
* foo if bar
* ```
*/
final Stmt getExpr() { result = range.getExpr() }
final Stmt getBody() { result = range.getBody() }
}
/**
@@ -172,7 +172,7 @@ class UnlessModifierExpr extends ConditionalExpr, @unless_modifier {
* foo unless bar
* ```
*/
final Stmt getExpr() { result = range.getExpr() }
final Stmt getBody() { result = range.getBody() }
}
/**

12
ql/src/codeql_ruby/ast/internal/Call.qll
View File

@@ -223,12 +223,12 @@ module BlockArgument {
class Range extends Expr::Range, @block_argument {
final override Generated::BlockArgument generated;
final Expr getExpr() { result = generated.getChild() }
final Expr getValue() { result = generated.getChild() }
final override string toString() { result = "&..." }
final override predicate child(string label, AstNode::Range child) {
label = "getExpr" and child = getExpr()
label = "getValue" and child = getValue()
}
}
}
@@ -237,12 +237,12 @@ module SplatArgument {
class Range extends Expr::Range, @splat_argument {
final override Generated::SplatArgument generated;
final Expr getExpr() { result = generated.getChild() }
final Expr getValue() { result = generated.getChild() }
final override string toString() { result = "*..." }
final override predicate child(string label, AstNode::Range child) {
label = "getExpr" and child = getExpr()
label = "getValue" and child = getValue()
}
}
}
@@ -251,12 +251,12 @@ module HashSplatArgument {
class Range extends Expr::Range, @hash_splat_argument {
final override Generated::HashSplatArgument generated;
final Expr getExpr() { result = generated.getChild() }
final Expr getValue() { result = generated.getChild() }
final override string toString() { result = "**..." }
final override predicate child(string label, AstNode::Range child) {
label = "getExpr" and child = getExpr()
label = "getValue" and child = getValue()
}
}
}

12
ql/src/codeql_ruby/ast/internal/Control.qll
View File

@@ -108,16 +108,16 @@ module IfModifierExpr {
final override Expr getCondition() { result = generated.getCondition() }
final Stmt getExpr() { result = generated.getBody() }
final Stmt getBody() { result = generated.getBody() }
final override Stmt getBranch(boolean cond) { cond = true and result = getExpr() }
final override Stmt getBranch(boolean cond) { cond = true and result = getBody() }
final override string toString() { result = "... if ..." }
override predicate child(string label, AstNode::Range child) {
ConditionalExpr::Range.super.child(label, child)
or
label = "getExpr" and child = getExpr()
label = "getBody" and child = getBody()
}
}
}
@@ -128,16 +128,16 @@ module UnlessModifierExpr {
final override Expr getCondition() { result = generated.getCondition() }
final Stmt getExpr() { result = generated.getBody() }
final Stmt getBody() { result = generated.getBody() }
final override Stmt getBranch(boolean cond) { cond = false and result = getExpr() }
final override Stmt getBranch(boolean cond) { cond = false and result = getBody() }
final override string toString() { result = "... unless ..." }
override predicate child(string label, AstNode::Range child) {
ConditionalExpr::Range.super.child(label, child)
or
label = "getExpr" and child = getExpr()
label = "getBody" and child = getBody()
}
}
}