mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
Make improvements based on PR feedback
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
using Xunit;
|
||||
using Semmle.Autobuild.Shared;
|
||||
using Semmle.Util;
|
||||
using System.Collections.Generic;
|
||||
using System;
|
||||
using System.Linq;
|
||||
@@ -79,10 +80,7 @@ namespace Semmle.Autobuild.Cpp.Tests
|
||||
{
|
||||
var ret = (this as IBuildActions).RunProcess(cmd, args, workingDirectory, env, out var stdout);
|
||||
|
||||
foreach (var line in stdout)
|
||||
{
|
||||
onOutput(line);
|
||||
}
|
||||
stdout.ForEach(line => onOutput(line));
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
||||
@@ -21,12 +21,10 @@ namespace Semmle.Autobuild.Cpp
|
||||
|
||||
public class CppAutobuilder : Autobuilder<CppAutobuildOptions>
|
||||
{
|
||||
private DiagnosticClassifier classifier;
|
||||
private readonly DiagnosticClassifier classifier;
|
||||
|
||||
public CppAutobuilder(IBuildActions actions, CppAutobuildOptions options) : base(actions, options)
|
||||
{
|
||||
public CppAutobuilder(IBuildActions actions, CppAutobuildOptions options) : base(actions, options) =>
|
||||
classifier = new DiagnosticClassifier();
|
||||
}
|
||||
|
||||
protected override DiagnosticClassifier DiagnosticClassifier => classifier;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user