Make improvements based on PR feedback

This commit is contained in:
Michael B. Gale
2023-02-22 12:29:10 +00:00
parent 8e83fd00b7
commit 0f320996cf
10 changed files with 60 additions and 69 deletions

View File

@@ -1,5 +1,6 @@
using Xunit;
using Semmle.Autobuild.Shared;
using Semmle.Util;
using System.Collections.Generic;
using System;
using System.Linq;
@@ -79,10 +80,7 @@ namespace Semmle.Autobuild.Cpp.Tests
{
var ret = (this as IBuildActions).RunProcess(cmd, args, workingDirectory, env, out var stdout);
foreach (var line in stdout)
{
onOutput(line);
}
stdout.ForEach(line => onOutput(line));
return ret;
}

View File

@@ -21,12 +21,10 @@ namespace Semmle.Autobuild.Cpp
public class CppAutobuilder : Autobuilder<CppAutobuildOptions>
{
private DiagnosticClassifier classifier;
private readonly DiagnosticClassifier classifier;
public CppAutobuilder(IBuildActions actions, CppAutobuildOptions options) : base(actions, options)
{
public CppAutobuilder(IBuildActions actions, CppAutobuildOptions options) : base(actions, options) =>
classifier = new DiagnosticClassifier();
}
protected override DiagnosticClassifier DiagnosticClassifier => classifier;