hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Use a field in RouterHandlerParameter

Browse Source
This commit is contained in:
Asger Feldthaus
2021-12-16 10:26:35 +01:00
parent 53b3581ed0
commit 0e9c2377e3
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javascript/ql/lib/semmle/javascript/Routing.qll
View File

@@ -818,7 +818,9 @@ module Routing {
* A parameter to a route handler function.
*/
class RouteHandlerParameter extends DataFlow::ParameterNode {
RouteHandlerParameter() { this = any(RouteHandler h).getFunction().getAParameter() }
private RouteHandler handler;
RouteHandlerParameter() { this = handler.getFunction().getAParameter() }
/** Gets a data flow node referring to this route handler parameter. */
private DataFlow::SourceNode ref(DataFlow::TypeTracker t) {
@@ -834,7 +836,7 @@ module Routing {
/**
* Gets the corresponding route handler, that is, the function on which this is a parameter.
*/
final RouteHandler getRouteHandler() { result.getFunction().getAParameter() = this }
final RouteHandler getRouteHandler() { result = handler }
/**
* Gets a node that is stored in the given access path on this route handler parameter, either
@@ -842,7 +844,7 @@ module Routing {
*/
pragma[inline]
DataFlow::Node getValueFromAccessPath(string path) {
exists(RouteHandler handler, int i, Node predecessor |
exists(int i, Node predecessor |
pragma[only_bind_out](this) = handler.getFunction().getParameter(i) and
result = getAnAccessPathRhs(predecessor, i, path) and
(handler.isGuardedByNode(predecessor) or predecessor = handler)