Polish tests

python/ql/test/experimental/query-tests/Security/CWE-943/flask_mongoengine_bad.py

@@ -1,18 +1,18 @@
 from flask import Flask, request
 from flask_mongoengine import MongoEngine
-import mongoengine as me
 import json
 
 app = Flask(__name__)
 db = MongoEngine(app)
+db.init_app(app)
 
 
-class Movie(me.Document):
-    title = me.StringField(required=True)
-    year = me.IntField()
-    rated = me.StringField()
-    director = me.StringField()
-    actors = me.ListField()
+class Movie(db.Document):
+    title = db.StringField(required=True)
+    year = db.IntField()
+    rated = db.StringField()
+    director = db.StringField()
+    actors = db.ListField()
 
 
 Movie(title='aa').save()
@@ -21,10 +21,10 @@ Movie(title='bb').save()
 
 @app.route("/")
 def home_page():
-    unsanitized_search = json.loads(request.args['search'])
+    unsanitized_search = request.args['search']
+    json_search = json.loads(unsanitized_search)
 
-    data = Movie.objects(__raw__=unsanitized_search)
-    return data.to_json()
+    result = Movie.objects(__raw__=json_search)
 
 # if __name__ == "__main__":
 #     app.run(debug=True)

python/ql/test/experimental/query-tests/Security/CWE-943/flask_mongoengine_good.py

@@ -1,19 +1,19 @@
 from flask import Flask, request
 from flask_mongoengine import MongoEngine
-import mongoengine as me
 from mongosanitizer.sanitizer import sanitize
 import json
 
 app = Flask(__name__)
 db = MongoEngine(app)
+db.init_app(app)
 
 
-class Movie(me.Document):
-    title = me.StringField(required=True)
-    year = me.IntField()
-    rated = me.StringField()
-    director = me.StringField()
-    actors = me.ListField()
+class Movie(db.Document):
+    title = db.StringField(required=True)
+    year = db.IntField()
+    rated = db.StringField()
+    director = db.StringField()
+    actors = db.ListField()
 
 
 Movie(title='aa').save()
@@ -22,11 +22,11 @@ Movie(title='bb').save()
 
 @app.route("/")
 def home_page():
-    unsanitized_search = json.loads(request.args['search'])
-    sanitize(unsanitized_search)
+    unsafe_search = request.args['search']
+    json_search = json.loads(unsafe_search)
+    safe_search = sanitize(json_search)
 
-    data = Movie.objects(__raw__=unsanitized_search)
-    return data.to_json()
+    result = Movie.objects(__raw__=safe_search)
 
 # if __name__ == "__main__":
 #     app.run(debug=True)

python/ql/test/experimental/query-tests/Security/CWE-943/flask_pymongo_bad.py

@@ -3,16 +3,15 @@ from flask_pymongo import PyMongo
 import json
 
 app = Flask(__name__)
-app.config["MONGO_URI"] = "mongodb://localhost:27017/testdb"
 mongo = PyMongo(app)
 
 
 @app.route("/")
 def home_page():
-    unsanitized_search = json.loads(request.args['search'])
+    unsanitized_search = request.args['search']
+    json_search = json.loads(unsanitized_search)
 
-    db_results = mongo.db.user.find({'name': unsanitized_search})
-    return db_results[0].keys()
+    result = mongo.db.user.find({'name': json_search})
 
 # if __name__ == "__main__":
 #     app.run(debug=True)

python/ql/test/experimental/query-tests/Security/CWE-943/flask_pymongo_good.py

@@ -4,17 +4,16 @@ from mongosanitizer.sanitizer import sanitize
 import json
 
 app = Flask(__name__)
-app.config["MONGO_URI"] = "mongodb://localhost:27017/testdb"
 mongo = PyMongo(app)
 
 
 @app.route("/")
 def home_page():
-    unsanitized_search = json.loads(request.args['search'])
-    sanitize(unsanitized_search)
+    unsafe_search = request.args['search']
+    json_search = json.loads(unsafe_search)
+    safe_search = sanitize(json_search)
 
-    db_results = mongo.db.user.find({'name': unsanitized_search})
-    return db_results[0].keys()
+    result = mongo.db.user.find({'name': safe_search})
 
 # if __name__ == "__main__":
 #    app.run(debug=True)

python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_bad.py

@@ -0,0 +1,28 @@
+from flask import Flask, request
+import mongoengine as me
+import json
+
+app = Flask(__name__)
+
+
+class Movie(me.Document):
+    title = me.StringField(required=True)
+    year = me.IntField()
+    rated = me.StringField()
+    director = me.StringField()
+    actors = me.ListField()
+
+
+Movie(title='aa').save()
+Movie(title='bb').save()
+
+
+@app.route("/")
+def home_page():
+    unsafe_search = request.args['search']
+    json_search = json.loads(unsafe_search)
+
+    data = Movie.objects(__raw__=json_search)
+
+# if __name__ == "__main__":
+#     app.run(debug=True)

python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_good.py

@@ -0,0 +1,30 @@
+from flask import Flask, request
+import mongoengine as me
+from mongosanitizer.sanitizer import sanitize
+import json
+
+app = Flask(__name__)
+
+
+class Movie(me.Document):
+    title = me.StringField(required=True)
+    year = me.IntField()
+    rated = me.StringField()
+    director = me.StringField()
+    actors = me.ListField()
+
+
+Movie(title='aa').save()
+Movie(title='bb').save()
+
+
+@app.route("/")
+def home_page():
+    unsafe_search = request.args['search']
+    json_search = json.loads(unsafe_search)
+    safe_search = sanitize(json_search)
+
+    data = Movie.objects(__raw__=safe_search)
+
+# if __name__ == "__main__":
+#     app.run(debug=True)

python/ql/test/experimental/query-tests/Security/CWE-943/pymongo_bad.py

@@ -8,10 +8,10 @@ client = MongoClient()
 
 @app.route("/")
 def home_page():
-    unsanitized_search = json.loads(request.args['search'])
+    unsafe_search = request.args['search']
+    json_search = json.loads(unsafe_search)
 
-    db_results = client.db.collection.find_one({'data': unsanitized_search})
-    return db_results[0].keys()
+    result = client.db.collection.find_one({'data': json_search})
 
 # if __name__ == "__main__":
 #     app.run(debug=True)

python/ql/test/experimental/query-tests/Security/CWE-943/pymongo_good.py

@@ -9,11 +9,11 @@ client = MongoClient()
 
 @app.route("/")
 def home_page():
-    unsanitized_search = json.loads(request.args['search'])
-    sanitize(unsanitized_search)
+    unsafe_search = request.args['search']
+    json_search = json.loads(unsafe_search)
+    safe_search = sanitize(json_search)
 
-    db_results = client.db.collection.find_one({'data': unsanitized_search})
-    return db_results[0].keys()
+    result = client.db.collection.find_one({'data': safe_search})
 
 # if __name__ == "__main__":
 #     app.run(debug=True)