hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Netty Response Splitting use CompileTimeConstantExpr

Browse Source 
Co-Authored-By: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
This commit is contained in:
Jonathan Leitschuh
2020-01-03 07:51:55 -05:00
committed by GitHub
parent b218374772
commit 0e2c5db7b1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/Security/CWE/CWE-113/NettyResponseSplitting.ql
View File

@@ -18,14 +18,14 @@ abstract private class InsecureNettyObjectCreation extends ClassInstanceExpr { }
private class InsecureDefaultHttpHeadersClassInstantiation extends InsecureNettyObjectCreation {
InsecureDefaultHttpHeadersClassInstantiation() {
getConstructedType().hasQualifiedName("io.netty.handler.codec.http", "DefaultHttpHeaders") and
getArgument(0).getProperExpr().(BooleanLiteral).getBooleanValue() = false
getArgument(0).(CompileTimeConstantExpr).getBooleanValue() = false
}
}
private class InsecureDefaultHttpResponseClassInstantiation extends InsecureNettyObjectCreation {
InsecureDefaultHttpResponseClassInstantiation() {
getConstructedType().hasQualifiedName("io.netty.handler.codec.http", "DefaultHttpResponse") and
getArgument(2).getProperExpr().(BooleanLiteral).getBooleanValue() = false
getArgument(2).(CompileTimeConstantExpr).getBooleanValue() = false
}
}