From 0e24ed14da7d0d464b9b427b807a628617755908 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Fri, 1 Mar 2024 17:04:34 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Anders Schack-Mulligen --- .../codeql/rangeanalysis/RangeAnalysis.qll | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll b/shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll index 688ee023900..f54d88b5d7c 100644 --- a/shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll +++ b/shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll @@ -276,7 +276,7 @@ signature module Semantic { } /** - * A single update to a variable in the SSA form. + * An SSA variable representing the value of an explicit update of the source variable. */ class SsaExplicitUpdate extends SsaVariable { /** @@ -374,17 +374,21 @@ signature module LangSig { signature module BoundSig { /** - * A semantic bound, which defines a constraint on the possible values of an - * expression. + * A bound that the range analysis can infer for a variable. This includes + * constant bounds represented by the abstract value zero, SSA bounds for when + * a variable is bounded by the value of a different variable, and possibly + * other abstract values that may be useful variable bounds. Since all bounds + * are combined with an integer delta there's no need to represent constant + * bounds other than zero. */ class SemBound { /** - * Gets a string representation of the semantic bound. + * Gets a string representation of this bound. */ string toString(); /** - * Gets the location of the semantic bound. + * Gets the location of this bound. */ Location getLocation();